From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: Fixing libvirt's libxl driver breakage -- where to
 define LIBXL_API_VERSION?
Date: Thu, 14 Apr 2016 20:05:26 +0200
Message-ID: <1460657126.13871.182.camel__47168.8784928576$1460657208$gmane$org@citrix.com>
References: <20160405113936.GA18120@citrix.com>	<570D6942.8020106@suse.com>
 <CAFLBxZbXDwPMXJT7q4CqEdfQS=nHgphzaysTmUQ-2bqXnGpfTg@mail.gmail.com>
 <570ED6B4.3060102@suse.com>	<1460619652.13871.130.camel@citrix.com>
 <22287.55938.127421.636018@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5341317747121206319=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([85.158.143.247])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=9053e2085=dario.faggioli@citrix.com>)
 id 1aqle1-0001OR-Bb
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2016 18:05:33 +0000
In-Reply-To: <22287.55938.127421.636018@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: LibVirt Development List <libvir-list@redhat.com>, Xen-devel <xen-devel@lists.xenproject.org>, Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============5341317747121206319==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-ffm8Ikz+3s988f/5zTZQ"

--=-ffm8Ikz+3s988f/5zTZQ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-04-14 at 18:59 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [Xen-devel] Fixing libvirt's libxl driver
> breakage -- where to define LIBXL_API_VERSION?"):
> >=20
> > And, in those cases, usage should be gated by the appropriate
> > LIBXL_HAVE_FOOBAR symbol, which I see in the sources (e.g.,
> > for=C2=A0LIBXL_HAVE_NO_SUSPEND_RESUME or=C2=A0LIBXL_HAVE_DOMAIN_NODEAFF=
INITY)
> > to
> > be the case, so good again. :-)
> If libvirt specifies LIBXL_API_VERSION then it does not need to check
> any LIBXL_HAVE_*, since it will actually get an API corresponding to
> the specified API_VERSION.
>=20
I concur. And in fact, this patch introduces an LIBXL_API_VERSION and
drops the use of LIBXL_HAVE_*.

And I think the patch is right. :-)

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-ffm8Ikz+3s988f/5zTZQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcP2+YACgkQk4XaBE3IOsRTkgCfYoEu/m1yhDzf8+33SeTpgKwa
On4AoJASx32htkmmjNnRcefCmN56aWXg
=hTrH
-----END PGP SIGNATURE-----

--=-ffm8Ikz+3s988f/5zTZQ--


--===============5341317747121206319==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============5341317747121206319==--