From: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, George.Dunlap@eu.citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xenproject.org, roger.pau@citrix.com
Subject: Re: [PATCH v3 6/7] libxl: Fix libxl_set_memory_target return value
Date: Mon, 09 May 2016 10:21:09 +0200 [thread overview]
Message-ID: <1462782069.7706.14.camel@localhost> (raw)
In-Reply-To: <20160427142904.GN20763@citrix.com>
On Wed, 2016-04-27 at 15:29 +0100, Wei Liu wrote:
> On Wed, Apr 20, 2016 at 10:04:03AM +0200, Paulina Szubarczyk wrote:
> > libxl_set_memory_target seems to have the following return values:
> >
> > * 1 on failure, if the failure happens because of a xenstore error *or*
> > * invalid target
> >
> > * -1 if the setmaxmem hypercall
>
> If the setmaxmem hypercall fails?
The setmaxmem hypercall returns -1 and sets errno on error and in fact
is the same behavior for set_pod_target. I am going to corrected the log
to:
"
'1' : on failure, if the failure happens because of a xenstore error
*or* invalid target
'-1': on error, the setmaxmem and set_pod_target hypercalls
return -1 and set errno appropriately.
"
>
> >
> > * -errno if the set_pod_target hypercall target fails
> >
> > * 0 on success
> >
> > Make it consistently return ERROR_FAIL on failure, unless the
> > parameters were invalid, in which case return ERROR_INVAL.
> >
>
> All in all the error code handling is not very sane in this function, so
> I'm fine with fixing it with something better.
>
> > In accordance with CODING_SYTLE:
> >
> > 1. Leave rc uninitialized, and set when an error is detected
> >
> > 2. Use 'r' for return values to functions whose return values are a
> > different error space (like xc_domain_setmaxmem and
> > xc_domain_set_pod_target)
> >
> > 3. Use 'lrc' for return values to local functions libxl__*
> > where a failure means retry, rather than fail the whole function
> > (libxl__fill_dom0_memory_info), to reduce the risk of that.
> >
> > Signed-off-by: George Dunlap <George.Dunlap@eu.citrix.com>
> > Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
>
> The code looks good to me.
Could you help me understand if the comments like "looks good to me"
should be marked in any way in resending packets?
> Wei.
Paulina
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-09 8:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 8:03 [PATCH v3 00/10] xl: improve coding style and return more failure on Paulina Szubarczyk
2016-04-20 8:03 ` [PATCH v3 1/7] libxl: improve return codes for some pci related functions Paulina Szubarczyk
2016-04-20 20:28 ` Olaf Hering
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:03 ` [PATCH v3 2/7] libxl: style cleanups in libxl_device_pci_assignable_list() Paulina Szubarczyk
2016-04-20 20:24 ` Olaf Hering
2016-04-21 7:17 ` Paulina Szubarczyk
2016-04-20 8:04 ` [PATCH v3 3/7] xl_cmdimpl: improve return codes for cd-insert commands Paulina Szubarczyk
2016-04-20 20:30 ` Olaf Hering
2016-04-20 8:04 ` [PATCH v3 4/7] xl_cmdimpl - Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove Paulina Szubarczyk
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 5/7] xl: improve main_tmem_* return codes Paulina Szubarczyk
2016-04-21 9:43 ` George Dunlap
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 6/7] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-04-20 20:56 ` Olaf Hering
2016-04-27 14:29 ` Wei Liu
2016-05-09 8:21 ` Paulina Szubarczyk [this message]
2016-05-09 9:48 ` George Dunlap
2016-05-09 11:15 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 7/7] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-04-20 21:04 ` Olaf Hering
2016-04-27 14:31 ` Wei Liu
2016-04-27 16:53 ` Dario Faggioli
2016-04-27 16:59 ` Wei Liu
2016-04-27 14:33 ` [PATCH v3 00/10] xl: improve coding style and return more failure on Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462782069.7706.14.camel@localhost \
--to=paulinaszubarczyk@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).