From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 2/3] VMX: Make hook pi_do_resume always
	available
Date: Mon, 23 May 2016 14:51:30 +0200
Message-ID: <1464007890.21930.57.camel@citrix.com>
References: <1463734431-22353-1-git-send-email-feng.wu@intel.com>
 <1463734431-22353-3-git-send-email-feng.wu@intel.com>
 <5743149A02000078000EDCEB@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1803595028050298479=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5743149A02000078000EDCEB@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>, Feng Wu <feng.wu@intel.com>
Cc: kevin.tian@intel.com, keir@xen.org, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============1803595028050298479==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-XzU0Z/p6K+aB6wlfAcQO"

--=-XzU0Z/p6K+aB6wlfAcQO
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2016-05-23 at 06:32 -0600, Jan Beulich wrote:
> > > > On 20.05.16 at 10:53, <feng.wu@intel.com> wrote:
> > @@ -247,13 +246,14 @@ void vmx_pi_hooks_deassign(struct domain *d)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d->arch.hvm_domain.vmx.vcpu_block =3D NUL=
L;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d->arch.hvm_domain.vmx.pi_switch_from =3D=
 NULL;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d->arch.hvm_domain.vmx.pi_switch_to =3D N=
ULL;
> > -=C2=A0=C2=A0=C2=A0=C2=A0d->arch.hvm_domain.vmx.pi_do_resume =3D NULL;
> > =C2=A0}
> > =C2=A0
> > =C2=A0static int vmx_domain_initialise(struct domain *d)
> > =C2=A0{
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int rc;
> > =C2=A0
> > +=C2=A0=C2=A0=C2=A0=C2=A0d->arch.hvm_domain.vmx.pi_do_resume =3D vmx_pi=
_do_resume;
> > +
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if ( !has_vlapic(d) )
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0;
> Along the lines of what I said last in for 1/3: There's no need to
> always install the hook. For your purpose it ought to suffice to
> simply not zap it upon device de-assign (which would still leave
> all VMs without passed through devices without such useless to
> them hook in place).
>=20
FWIW, +1 to this.

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-XzU0Z/p6K+aB6wlfAcQO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXQvzSAAoJEBZCeImluHPusaYP/A+VRnyubj4MnN44BPSJRf+F
/LLn0SVUHwV6saGs8EUr0E8GC57KJm4r/3XqYgSsY3VyFnSZrEKTl6loJYECWKIf
Iys9vbsHSNd6jr6VUhHcUypkxAEQUq7tEQ92P4L2kbcwav0xoURqkMH8t28eOSvs
wcxFAm1PkPamwtwV1/8yQYVAcS8J6ltWwSQo99y9sQlK+Psj0cbPOqQXE9FPFbls
LDv8YtFLLrdVQc1HxXW083ZBFDXY2ckUkOmw8CPsXwBirrslbYTFGGGxrhdpwGKH
KdDli2EmAtzZgvWZLJ117oBfijFHsydW2KJPIARQ0XBfVlqzjUmQkRMReJ+iO0FT
aQ9lNXY3c/QuGskKTEtR6gW/CqIsy1Mbd1KA/lpO7nr3Fgtrpvi3LtaCsrPLq6th
yZ1jN+KpAp+ltZFdJK3JtAZa31XymJ4YVH4TXyFpJ8E7ZHbADVnKeXPT3bYLNwrX
7HEbNK5eDgwCTvUpwtYCa94CsTUU5l0kcFQM3leQraCD90yIYVJCT1r8u0FHh2FO
w86+eWz7I50ui70d4GDAr+BrzRVWpkQavZZH5jqEkyGmSCaoJ6CWMn8HC/OTnchE
jqXp0CjXE61CiuTET+lJblg93s2aIFr5gHXCN9M9ov2w63VKV9qGvgwm3yz29f56
23byO3L4dsW1dGe9sb5j
=xZf4
-----END PGP SIGNATURE-----

--=-XzU0Z/p6K+aB6wlfAcQO--


--===============1803595028050298479==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============1803595028050298479==--