From: "Xu, Quan" <quan.xu@intel.com>
To: xen-devel@lists.xen.org
Cc: Quan Xu <quan.xu@intel.com>,
kevin.tian@intel.com, feng.wu@intel.com,
dario.faggioli@citrix.com, jbeulich@suse.com
Subject: [Patch v11 0/3] VT-d Device-TLB flush issue
Date: Wed, 1 Jun 2016 17:05:19 +0800 [thread overview]
Message-ID: <1464771922-7794-1-git-send-email-quan.xu@intel.com> (raw)
From: Quan Xu <quan.xu@intel.com>
This patches fix current timeout concern and also allow limited ATS support:
1. add a timeout parameter for device IOTLB invalidation
The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of the device
IOTLB invalidation in milliseconds. By default, the timeout is 1ms, which can
be boot-time changed.
2. Synchronize for Device-TLB flush one by one
Today we do Device-TLB flush synchronization after issuing flush
requests for all ATS devices belonging to a VM. Doing so however
imposes a limitation, i.e. that we can not figure out which flush
request is blocked in the flush queue list, based on VT-d spec.
To prepare correct Device-TLB flush timeout handling in next patch,
we change the behavior to synchronize for every Device-TLB flush
request. So the Device-TLB flush interface is changed a little bit,
by checking timeout within the function instead of outside of function.
Accordingly we also do a similar change for flush interfaces of
IOTLB/IEC/Context, i.e. moving synchronization into the function.
Since there is no user of a non-synced interface, we just rename
existing ones with _sync suffix.
3. Fix vt-d Device-TLB flush timeout issue
If Device-TLB flush timed out, we hide the target ATS device
immediately and crash the domain owning this ATS device. If
impacted domain is hardware domain, just throw out a warning.
By hiding the device, we make sure it can't be assigned to any
domain any longer (see device_assigned).
**NOTE**
This patch set should base on one prereq patch sets:
a). Check VT-d Device-TLB flush error.
----
Not covered in this series:
a) Eliminate the panic() in IOMMU_WAIT_OP, used only in VT-d register read/write.
Further discussion is required on whether and how to improve it.
b) Handle IOTLB/Context/IEC flush timeout.
Quan Xu (3):
IOMMU: add a timeout parameter for device IOTLB invalidation
vt-d: synchronize for Device-TLB flush one by one
vt-d: fix vt-d Device-TLB flush timeout issue
docs/misc/xen-command-line.markdown | 9 ++
xen/drivers/passthrough/iommu.c | 3 +
xen/drivers/passthrough/pci.c | 6 +-
xen/drivers/passthrough/vtd/extern.h | 6 +-
xen/drivers/passthrough/vtd/qinval.c | 157 ++++++++++++++++++++++++++--------
xen/drivers/passthrough/vtd/x86/ats.c | 7 +-
xen/include/xen/iommu.h | 2 +
xen/include/xen/pci.h | 1 +
8 files changed, 144 insertions(+), 47 deletions(-)
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-06-01 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:05 Xu, Quan [this message]
2016-06-01 9:05 ` [Patch v11 1/3] IOMMU: add a timeout parameter for device IOTLB invalidation Xu, Quan
2016-06-02 10:24 ` Jan Beulich
2016-06-15 2:55 ` Xu, Quan
2016-06-01 9:05 ` [Patch v11 2/3] vt-d: synchronize for Device-TLB flush one by one Xu, Quan
2016-06-02 10:49 ` Jan Beulich
2016-06-01 9:05 ` [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue Xu, Quan
2016-06-02 11:07 ` Jan Beulich
2016-06-16 8:42 ` Xu, Quan
2016-06-16 9:04 ` Jan Beulich
2016-06-17 6:08 ` Xu, Quan
2016-06-17 7:00 ` Jan Beulich
2016-06-17 8:15 ` Xu, Quan
2016-06-17 8:40 ` Jan Beulich
2016-06-22 15:54 ` Xu, Quan
2016-06-22 16:18 ` Jan Beulich
2016-06-23 2:08 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464771922-7794-1-git-send-email-quan.xu@intel.com \
--to=quan.xu@intel.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).