xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk"
Date: Wed, 8 Jun 2016 16:31:04 +0100	[thread overview]
Message-ID: <1465399864-9711-1-git-send-email-wei.liu2@citrix.com> (raw)

This reverts c0c099d157cc5bc942afef766cf141628a6380a1.

That commit causes regression on the semantics of our diskspec.
See [0] for more information.

[0] http://lists.xen.org/archives/html/xen-devel/2016-05/msg02876.html

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Please review carefully about this patch. There are one commit that is
of interest: ef6cb76026628e26e3d1ae53c50ccde1c3c78b1b

I believe the reverting the snippet in question won't cause security
issue as described in XSA-142, because the code to create IDE disk still
checks if the disk is read-only.
---
 tools/libxl/libxl_dm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 155a653..6ff05c3 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1422,12 +1422,6 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
                                                         format,
                                                         &disks[i],
                                                         colo_mode);
-                } else if (strncmp(disks[i].vdev, "xvd", 3) == 0) {
-                    /*
-                     * Do not add any emulated disk when PV disk are
-                     * explicitly asked for.
-                     */
-                    continue;
                 } else if (disk < 6 && b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI) {
                     if (!disks[i].readwrite) {
                         LOG(ERROR, "qemu-xen doesn't support read-only AHCI disk drivers");
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2016-06-08 15:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 15:31 Wei Liu [this message]
2016-06-08 15:32 ` [PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk" Ian Jackson
2016-06-08 15:52   ` Wei Liu
2016-06-08 16:00     ` George Dunlap
2016-06-08 16:17       ` Olaf Hering
2016-06-08 17:55         ` Konrad Rzeszutek Wilk
2016-06-09 13:23           ` Olaf Hering
2016-06-13  8:41             ` George Dunlap
2016-06-13 10:21               ` Olaf Hering
2016-06-13 10:23                 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465399864-9711-1-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).