From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulina Szubarczyk Subject: Re: [PATCH v2 2/2] qdisk - hw/block/xen_disk: grant copy implementation Date: Mon, 13 Jun 2016 12:44:27 +0200 Message-ID: <1465814667.17840.11.camel@localhost> References: <1465811036-17026-1-git-send-email-paulinaszubarczyk@gmail.com> <1465811036-17026-3-git-send-email-paulinaszubarczyk@gmail.com> <575E87C0.5030609@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCPNK-0002A6-Fa for xen-devel@lists.xenproject.org; Mon, 13 Jun 2016 10:45:46 +0000 Received: by mail-lf0-f66.google.com with SMTP id u74so10905103lff.0 for ; Mon, 13 Jun 2016 03:45:45 -0700 (PDT) In-Reply-To: <575E87C0.5030609@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: David Vrabel Cc: sstabellini@kernel.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, P.Gawkowski@ii.pw.edu.pl, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAyMDE2LTA2LTEzIGF0IDExOjE1ICswMTAwLCBEYXZpZCBWcmFiZWwgd3JvdGU6Cj4g T24gMTMvMDYvMTYgMTA6NDMsIFBhdWxpbmEgU3p1YmFyY3p5ayB3cm90ZToKPiA+IENvcHkgZGF0 YSBvcGVyYXRlZCBvbiBkdXJpbmcgcmVxdWVzdCBmcm9tL3RvIGxvY2FsIGJ1ZmZlcnMgdG8vZnJv bSAKPiA+IHRoZSBncmFudCByZWZlcmVuY2VzLiAKPiA+IAo+ID4gQmVmb3JlIGdyYW50IGNvcHkg b3BlcmF0aW9uIGxvY2FsIGJ1ZmZlcnMgbXVzdCBiZSBhbGxvY2F0ZWQgd2hhdCBpcyAKPiA+IGRv bmUgYnkgY2FsbGluZyBpb3JlcV9pbml0X2NvcHlfYnVmZmVycy4gRm9yIHRoZSAncmVhZCcgb3Bl cmF0aW9uLCAKPiA+IGZpcnN0LCB0aGUgcWVtdSBkZXZpY2UgaW52b2tlcyB0aGUgcmVhZCBvcGVy YXRpb24gb24gbG9jYWwgYnVmZmVycyAKPiA+IGFuZCBvbiB0aGUgY29tcGxldGlvbiBncmFudCBj b3B5IGlzIGNhbGxlZCBhbmQgYnVmZmVycyBhcmUgZnJlZWQuIAo+ID4gRm9yIHRoZSAnd3JpdGUn IG9wZXJhdGlvbiBncmFudCBjb3B5IGlzIHBlcmZvcm1lZCBiZWZvcmUgaW52b2tpbmcgCj4gPiB3 cml0ZSBieSBxZW11IGRldmljZS4gCj4gPiAKPiA+IEEgbmV3IHZhbHVlICdmZWF0dXJlX2dyYW50 X2NvcHknIGlzIGFkZGVkIHRvIHJlY29nbml6ZSB3aGVuIHRoZSAKPiA+IGdyYW50IGNvcHkgb3Bl cmF0aW9uIGlzIHN1cHBvcnRlZCBieSBhIGd1ZXN0LiAKPiA+IFRoZSBib2R5IG9mIHRoZSBmdW5j dGlvbiAnaW9yZXFfcnVuaW9fcWVtdV9haW8nIGlzIG1vdmVkIHRvIAo+ID4gJ2lvcmVxX3J1bmlv X3FlbXVfYWlvX2JsaycgYW5kIGluIHRoZSAnaW9yZXFfcnVuaW9fcWVtdV9haW8nIGRlcGVuZGlu Zwo+ID4gb24gdGhlIHN1cHBvcnQgZm9yIGdyYW50IGNvcHkgYWNjb3JkaW5nIGNoZWNrcywgaW5p dGlhbGl6YXRpb24sIGdyYW50IAo+ID4gb3BlcmF0aW9uIGFyZSBtYWRlLCB0aGVuIHRoZSAnaW9y ZXFfcnVuaW9fcWVtdV9haW9fYmxrJyBmdW5jdGlvbiBpcyAKPiA+IGNhbGxlZC4gCj4gCj4gSSB0 aGluayB5b3Ugc2hvdWxkIGFkZCBhbiBvcHRpb24gdG8gZm9yY2UgdGhlIHVzZSBvZiBncmFudCBt YXBwaW5nIGV2ZW4KPiBpZiBjb3B5IHN1cHBvcnQgaXMgZGV0ZWN0ZWQuICBJZiBmdXR1cmUgY2hh bmdlcyB0byB0aGUgZ3JhbnQgbWFwCj4gaW5mcmFzdHJ1Y3R1cmUgbWFrZXMgaXQgZmFzdGVyIG9y IGlmIGdyYW50IG1hcCBzY2FsZXMgYmV0dGVyIGluIHNvbWUKPiBzeXN0ZW1zLCB0aGVuIGl0IHdv dWxkIGJlIHVzZWZ1bCB0byBiZSBhYmxlIHRvIHVzZSBpdC4KClRoZSAnZmVhdHVyZV9ncmFudF9j b3B5JyBpcyBhIGJvb2xlYW4gYW5kIGNvdWxkIGJlIHNldCB0byBmYWxzZSBpbiBzdWNoIGNhc2Uu ClRoZXJlIGNvdWxkIGJlIGFkZGVkIGEgbm9kZSBpbiBYZW5TdG9yZSwgZm9yIGV4YW1wbGUKJ2Zl YXR1cmUtZm9yY2UtZ3JhbnQtbWFwJywgd2hpY2ggd2hlbiBzZXQgYnkgZnJvbnRlbmQgd2lsbCBi ZSByZWFkCmR1cmluZyBhIGNvbm5lY3Rpb24gYW5kIGNoYW5nZWQgdGhlIHZhbHVlIHRvIGZhbHNl IGZvcmNpbmcgdGhlIGdyYW50IG1hcApvcGVyYXRpb24uIAoKPiA+ICsgICAgcmMgPSB4Y19nbnR0 YWJfZ3JhbnRfY29weShnbnQsIGNvdW50LCBzZWdzKTsKPiA+ICsKPiA+ICsgICAgaWYgKHJjKSB7 Cj4gPiArICAgICAgICB4ZW5fYmVfcHJpbnRmKCZpb3JlcS0+YmxrZGV2LT54ZW5kZXYsIDAsIAo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAiZmFpbGVkIHRvIGNvcHkgZGF0YSAlZCBcbiIsIHJj KTsKPiAKPiBJIGRvbid0IHRoaW5rIHlvdSB3YW50IHRvIGxvZyBhbnl0aGluZyBoZXJlLiAgQSBn dWVzdCBjb3VsZCBzcGFtIHRoZQo+IGxvZ3MgYnkgcmVwZWF0ZWRseSBzdWJtaXR0aW5nIHJlcXVl c3RzIHdpdGggKGZvciBleGFtcGxlKSBiYWQgZ3JhbnQKPiByZWZlcmVuY2VzLgoKSSBtaWdodCBy ZW1vdmVkIHRoYXQgbG9nIG9yIGNoYW5nZSB0aGUgbGV2ZWwsIHRob3VnaCB3aGVuIHRoZSBtYXBw aW5nCmZhaWxzIGZvciBncmFudCBtYXAgaXQgaXMgbG9nZ2VkIGluIGEgc2ltaWxhciBtYW5uZXIu Cgo+ID4gKyAgICAgICAgaW9yZXEtPmFpb19lcnJvcnMrKzsKPiA+ICsgICAgICAgIHIgPSAtMTsg Z290byBvdXQ7Cj4gCj4gcmV0dXJuIC0xOwo+IAo+ID4gQEAgLTEwMjAsMTAgKzExNjMsMTggQEAg c3RhdGljIGludCBibGtfY29ubmVjdChzdHJ1Y3QgWGVuRGV2aWNlICp4ZW5kZXYpCj4gPiAgCj4g PiAgICAgIHhlbl9iZV9iaW5kX2V2dGNobigmYmxrZGV2LT54ZW5kZXYpOwo+ID4gIAo+ID4gKyAg ICB4Y19nbnR0YWJfZ3JhbnRfY29weV9zZWdtZW50X3Qgc2VnOwo+ID4gKyAgICBibGtkZXYtPmZl YXR1cmVfZ3JhbnRfY29weSA9IAo+ID4gKyAgICAgICAgICAgICAgICAoeGNfZ250dGFiX2dyYW50 X2NvcHkoYmxrZGV2LT54ZW5kZXYuZ250dGFiZGV2LCAwLCAmc2VnKSA9PSAwKTsKPiAKPiBZb3Ug Y2FuIHBhc3MgTlVMTCBmb3IgdGhlIHNlZ21lbnRzIGhlcmUuCgpZZXMsIHRoYW5rIHlvdS4KPiAK PiA+ICsKPiA+ICsgICAgeGVuX2JlX3ByaW50ZigmYmxrZGV2LT54ZW5kZXYsIDMsICJHUkFOVCBD T1BZICVzXG4iLCAKPiA+ICsgICAgICAgICAgICAgICAgICBibGtkZXYtPmZlYXR1cmVfZ3JhbnRf Y29weSA/ICJFTkFCTEVEIiA6ICJESVNBQkxFRCIpOwo+ID4gKwo+ID4gICAgICB4ZW5fYmVfcHJp bnRmKCZibGtkZXYtPnhlbmRldiwgMSwgIm9rOiBwcm90byAlcywgcmluZy1yZWYgJWQsICIKPiA+ ICAgICAgICAgICAgICAgICAgICAicmVtb3RlIHBvcnQgJWQsIGxvY2FsIHBvcnQgJWRcbiIsCj4g PiAgICAgICAgICAgICAgICAgICAgYmxrZGV2LT54ZW5kZXYucHJvdG9jb2wsIGJsa2Rldi0+cmlu Z19yZWYsCj4gPiAgICAgICAgICAgICAgICAgICAgYmxrZGV2LT54ZW5kZXYucmVtb3RlX3BvcnQs IGJsa2Rldi0+eGVuZGV2LmxvY2FsX3BvcnQpOwo+ID4gKwo+ID4gICAgICByZXR1cm4gMDsKPiA+ ICB9Cj4gCj4gRGF2aWQKPiAKUGF1bGluYQoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=