From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 1/2] xen: sched: rtds refactor code
Date: Fri, 24 Jun 2016 09:45:42 +0200
Message-ID: <1466754342.18398.85.camel@citrix.com>
References: <1463356490-9780-1-git-send-email-tiche@seas.upenn.edu>
 <1463356490-9780-2-git-send-email-tiche@seas.upenn.edu>
 <CAFLBxZYu2qZPqX3D6D2Rv3A_p5KW2D2vfs9usG2eH08yqgSF_w@mail.gmail.com>
 <CAENZ-+=CmAuZF1pGdgXM6EDvVDhi8r13i=BrTZTWSJ0kXJvj_g@mail.gmail.com>
 <9ace7d3c-886c-6a57-644a-54fcf448854f@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2518355168737224602=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([85.158.143.247])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=976b53656=dario.faggioli@citrix.com>)
 id 1bGLoF-0008N1-KM
 for xen-devel@lists.xenproject.org; Fri, 24 Jun 2016 07:45:51 +0000
In-Reply-To: <9ace7d3c-886c-6a57-644a-54fcf448854f@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, Meng Xu <mengxu@cis.upenn.edu>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Tianyang Chen <tiche@seas.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

--===============2518355168737224602==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-Z9sLDStyTTsHG2HKsR43"

--=-Z9sLDStyTTsHG2HKsR43
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-06-23 at 11:42 +0100, George Dunlap wrote:
> On 22/06/16 17:16, Meng Xu wrote:
> >=C2=A0
> > I think he is trying to align those comments to make them start
> > from
> > the same column. I was confused at the reason at the very
> > beginning.
> > Then I pulled his repo and checked this change.
> Right -- well neither you as a reviewer nor anyone in the future
> looking
> back at this changeset should have to try to guess what the purpose
> was;
> if he did want to align them, that's perfectly fine, it just needs a
> brief mention in the changelog. :-)
>=20
Indeed. BTW, I don't recall if we discussed this alignment
previously,neither, in case we did, what my position was back then :-P

In any case, I (now) think that having these comments aligned on a
per-struct base is just fine, and there really is no need to have _all_
of them aligned, across all structs.

I don't have a super strong opinion on this, and I'd be fine with it,
if Meng is. I just think it's not worth the effort (of patching,
reviewing, checking in, etc.)

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-Z9sLDStyTTsHG2HKsR43
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXbOUmAAoJEBZCeImluHPu9jQQALOcmZKUO33uhu/FEOmnEHJH
N26NURLiKM8ORR2weQedlVjZu2tZYjin6pSOP73n4H6y2WYbOBFAeJGFiTeOxul7
PCna+lnimhtx8bzQKCqcjgsNIcQEwzPe8AUBRjuBr10R0iW6xdwjzGFfKCEMw3K5
1rsLMBXsDlrkn8LCYtOfbUwcsDAIpoCnvUbeGj0hp7ibz4blmooAjn/68cwpP8hg
bXIKTnYH+ND5ExKphQ9XFxd6lKzVG0NiBNrLydu4ujDofG/uytsgqhsxbgTSiidR
TdWR3+ibtZu0zyGHGifUETiQyb4tvKvp6wHr5QwhKNlkueEf6sk83ALBWHmNr5M/
B0dHvJPGJzpnTEcEQBPvZX+wqCZFpncsEKCOBFehcc8kgT8BHzMqda/c0n+TGUow
BZZqwCmDpoKIadOC1aRcHozu6mJKJVfyzhhZvQ29IqE9WJSw/duayxvV96M4sxuj
eESvA2Yvtv08txzj7PXdPRPVdYe8mICq8b5HOn35mTab7ImY9WlY1hdgXlvG8E5K
xvYm2V+6R4jbGPAyLNhEUVzNkp+Prm/oJjVOXqbDetJtnusC2iOchOsdXASXT4K1
Ta3DMEDe8y4get8+rQwte7Y70ECyIn6H9rx7WXMwg/LO7rQJRpkwDXifwApTWpnx
qXe5AGKMzzQhm1fqft42
=pmXm
-----END PGP SIGNATURE-----

--=-Z9sLDStyTTsHG2HKsR43--


--===============2518355168737224602==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============2518355168737224602==--