From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 01/19] xen: sched: leave CPUs doing tasklet work alone. Date: Thu, 7 Jul 2016 12:25:25 +0200 Message-ID: <1467887125.23985.46.camel@citrix.com> References: <146620492155.29766.10321123657058307698.stgit@Solace.fritz.box> <146620508199.29766.7439697154591443704.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6108359485927728610==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL6Ut-00019N-7a for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 10:25:31 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar , David Vrabel List-Id: xen-devel@lists.xenproject.org --===============6108359485927728610== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Ul0h7t337k6AOeE1DeGR" --=-Ul0h7t337k6AOeE1DeGR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-07-06 at 16:41 +0100, George Dunlap wrote: > On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli >=C2=A0 > > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c > > index a38a63d..a6645a2 100644 > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -1819,24 +1819,24 @@ csched_schedule( > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0snext =3D csched_= load_balance(prv, cpu, snext, > > &ret.migrated); > >=20 > > + out: > Sorry if I'm being a bit dense, but why is this moving up here?=C2=A0=C2= =A0As > far as I can tell the only time the 'out' label will be used, the > 'idler' status of the cpu cannot change. >=20 Mmm... I think you're right. If we go to out:, we are running someone (so we are not idle), and we will continue to do so (so we should not be marked as idle). I seem to recall having seen something because of which out needed bubbling up, but I don't any longer right now, so I'll leave it alone. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Ul0h7t337k6AOeE1DeGR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXfi4VAAoJEBZCeImluHPujo4P/0r+R3fmmeQ1kMcVJgkldLYn 7RnpCo9azgZeWHg8bR1GPCXVz20BdaAa6xEXhMuLQTGv8p9Kp4mU8k7GetiYkj4C qcDkGsIC4R/eDHx5B/vITx/RkoIwPjixSJLUsWaq5PYno6jmCr3vIfP5rVgqvH/B aSPbBZoeJsR7HwOh4Mhkp1SMwmLFEjKjNC2rphkGS5c2wapzl4PoqJmzuyEyIMcS exLzFk0rQ6l07/F/Hiqrc/zf8kzOukedtjkzWUIQt/AA1pZTKoeK0bouyJsAiLaw zsVVXrRpznBVxjUn5Fq+sGzCHB9Ulba3rvL7eD4mfv71tu6Wlg6NTGYn49OlbiZQ We8J4uc1V6OcXfZ5Yi0+mNIUjIBL+CSLimjXBTt7bcPVEnzr9jwUtvOUeKA5aGjt UqIrAPY+JFQ3qusu+NwMhaFhQZ8VP5Yx6Wb+2TF5zUGqZd6NQAm3JCpOblPNkhPF 95wP+kueHv8moYBKtMcRSlQx2Li3ihFFG5T/SqIWuIE0vDTAxMJY1xcGr7uINnZt 7mPiDEorFakz7Cl+KZf86qAZrgMb81K9BkPOeNrqD/JC6ua0uGpiFnBVRjznJvne w4oFxt1Ny/238dQEXQQMx5bOxR9jFdLgpBA4IBDawluMnnh8uCJi7IjXcW+zmGP0 PyRyUAwRemGLKS3zC6Sk =AA2e -----END PGP SIGNATURE----- --=-Ul0h7t337k6AOeE1DeGR-- --===============6108359485927728610== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============6108359485927728610==--