From: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>
To: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Cc: "jgross@suse.com" <jgross@suse.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH] xen/apic: Update the comment for apic_id_mask
Date: Wed, 13 Jul 2016 07:56:10 +0000 [thread overview]
Message-ID: <1468396427.2020.14.camel__17262.8739303493$1468396667$gmane$org@localhost> (raw)
In-Reply-To: <ecc08a4e-1f13-f7a3-5b45-ba5ac71cd417@oracle.com>
On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote:
> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
> > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
> >> verify_local_APIC() had been removed by
> >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
> >> so apic_id_mask isn't used by it.
>
> Is anyone actually using this field? It looks like 4399c03c6780 removed
> the only user.
Indeed, the field is useless.
Maybe we can remove this field from the struct apic .
what's your opinion?
Thanks,
wei
>
> -boris
>
>
> > CC-ing the proper maintainers.
> >> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> >> ---
> >> arch/x86/xen/apic.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
> >> index db52a7fafcc2..9cbb1f48381b 100644
> >> --- a/arch/x86/xen/apic.c
> >> +++ b/arch/x86/xen/apic.c
> >> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
> >>
> >> .get_apic_id = xen_get_apic_id,
> >> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
> >> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
> >> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
> >>
> >> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
> >>
> >> --
> >> 1.9.3
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xen.org
> >> https://lists.xen.org/xen-devel
>
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-13 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com>
2016-07-07 15:25 ` [PATCH] xen/apic: Update the comment for apic_id_mask Konrad Rzeszutek Wilk
[not found] ` <20160707152510.GJ17766@localhost.localdomain>
2016-07-07 15:37 ` Boris Ostrovsky
2016-07-13 7:56 ` Wei, Jiangang [this message]
[not found] ` <1468396427.2020.14.camel@localhost>
2016-07-13 18:51 ` Boris Ostrovsky
2016-07-07 3:28 Wei Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1468396427.2020.14.camel__17262.8739303493$1468396667$gmane$org@localhost' \
--to=weijg.fnst@cn.fujitsu.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).