From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <jgrall@amazon.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] pvcalls: Document explicitly the padding for all arches
Date: Wed, 29 Apr 2020 17:23:01 +0200 [thread overview]
Message-ID: <1494fe06-b353-00a5-17a6-c11cee269519@suse.com> (raw)
In-Reply-To: <d9d7c77c-35d2-9096-7c4b-49f6d0931d5e@xen.org>
On 29.04.2020 17:06, Julien Grall wrote:
>
>
> On 29/04/2020 15:56, Jan Beulich wrote:
>> On 29.04.2020 16:14, Julien Grall wrote:
>>> Hi Jan,
>>>
>>> On 29/04/2020 15:05, Jan Beulich wrote:
>>>> On 29.04.2020 16:01, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 22/04/2020 10:20, Jan Beulich wrote:
>>>>>>> Even if it was possible to use the sub-structs defined in the header
>>>>>>> that way, keep in mind that we also wrote:
>>>>>>>
>>>>>>> /* dummy member to force sizeof(struct xen_pvcalls_request)
>>>>>>> * to match across archs */
>>>>>>> struct xen_pvcalls_dummy {
>>>>>>> uint8_t dummy[56];
>>>>>>> } dummy;
>>>>>>
>>>>>> This has nothing to do with how a consumer may use the structs.
>>>>>>
>>>>>>> And the spec also clarifies that the size of each specific request is
>>>>>>> always 56 bytes.
>>>>>>
>>>>>> Sure, and I didn't mean to imply that a consumer would be allowed
>>>>>> to break this requirement. Still something like this
>>>>>>
>>>>>> int pvcall_new_socket(struct xen_pvcalls_socket *s) {
>>>>>> struct xen_pvcalls_request req = {
>>>>>> .req_id = REQ_ID,
>>>>>> .cmd = PVCALLS_SOCKET,
>>>>>> .u.socket = *s,
>>>>>> };
>>>>>>
>>>>>> return pvcall(&req);
>>>>>> }
>>>>>>
>>>>>> may break.
>>>>>
>>>>> I think I understand your concern now. So yes I agree this would break 32-bit consumer.
>>>>>
>>>>> As the padding is at the end of the structure, I think a 32-bit frontend and 64-bit backend (or vice-versa) should currently work without any trouble. The problem would come later if we decide to extend a command.
>>>>
>>>> Can commands be extended at all, i.e. don't extensions require new
>>>> commands? The issue I've described has nothing to do with future
>>>> extending of any of the affected structures.
>>>
>>> I think my point wasn't conveyed correctly. The implicit padding is at
>>> the end of the structure for all the consumers but 32-bit x86. So
>>> without any modification, I think 32-bit frontend can still communicate
>>> with 64-bit backend (or vice-versa).
>>
>> There's no issue communicating afaics, as for communication
>> you wouldn't use the sub-structures, but the single container
>> one. The problem is, as described, with possible uses internal
>> to one side of the communication.
>
> I am sorry but I can't figure out how this is an issue. The
> problem you described would only happen if you are calling a
> 64-bit library from a 32-bit software.
Why? The example given doesn't require such.
> Is it even possible?
In principle yes, I think. I don't think OSes like Linux allow this,
though.
Jan
next prev parent reply other threads:[~2020-04-29 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 10:49 [PATCH] pvcalls: Document explicitly the padding for all arches Julien Grall
2020-04-20 8:04 ` Jan Beulich
2020-04-20 13:34 ` Julien Grall
2020-04-20 13:45 ` Jan Beulich
2020-04-21 23:27 ` Stefano Stabellini
2020-04-22 9:20 ` Jan Beulich
2020-04-29 14:01 ` Julien Grall
2020-04-29 14:05 ` Jan Beulich
2020-04-29 14:14 ` Julien Grall
2020-04-29 14:56 ` Jan Beulich
2020-04-29 15:06 ` Julien Grall
2020-04-29 15:23 ` Jan Beulich [this message]
2020-04-29 15:30 ` Julien Grall
2020-04-29 15:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494fe06-b353-00a5-17a6-c11cee269519@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgrall@amazon.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).