On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > First, move some code around in order to make the next change more > obvious. > > commit 16c047add3ceaf0ab882e3e094d1ec904d02312d from linux tree > > Signed-off-by: Praveen Kumar > Mmm... actually, I am not absolutely sure of what's the formal process that we follow in this case is, but I think that: *) it is legally required (or at least preferable) that, at least the  Signed-off-by, of the original authors of the patches are reported  here; *) legally required or not, I think it's very useful to have them, and  not only the S-o-b, but also the Acks, and all the other tags (like  you had in the first posting of this series). You probably should  add your own Signed-off-by, at the bottom of the list (this, you  didn't do it in first posting of the series) I appreciate that you probably removed the tags to prevent git-send- email to use the enclosed email address and spam everyone, but I'm sure there is a way of telling git-send-email itself, to avoid doing that, even if you leave the tags and the emails in the patches' changelogs (something like a command line options, or similar.. I don't use it, so I can't tell). Regards, Dario -- <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)