From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 4/4] libxl/xl: allow to get and set cap on Credit2. Date: Thu, 29 Jun 2017 12:22:29 +0200 Message-ID: <1498731749.7288.16.camel@citrix.com> References: <149692186557.9605.11625777539060264052.stgit@Solace.fritz.box> <149692374884.9605.7936271678792382781.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7864037340163474320==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQWaq-0006Y7-Nk for xen-devel@lists.xenproject.org; Thu, 29 Jun 2017 10:22:36 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar , Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org --===============7864037340163474320== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Q/xTCCNCCzfjRAu6Rn8i" --=-Q/xTCCNCCzfjRAu6Rn8i Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-06-28 at 19:43 +0100, George Dunlap wrote: > On Thu, Jun 8, 2017 at 1:09 PM, Dario Faggioli > wrote: > > Note that a cap is considered valid only if > > it is within the [1, nr_vcpus]% interval. >=20 > Oh, I see you added the check here. >=20 Yeah... > Still, I think we should add a check in the hypervisor too.=C2=A0=C2=A0Th= e > check > here should mainly be to give a reasonable error message; we > shouldn't > rely on it for safety. >=20 ...sure, I totally agree. Will do. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Q/xTCCNCCzfjRAu6Rn8i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZVNTlAAoJEBZCeImluHPuv5UQAM/TkhItuWZB5MjFneNxFlsO 9YhYyiHbQOHfip2qlkRlCDacNz1kYDDeWaD7ZcDf3rjPTOD3twfvwBqzT/1Cxv+R fjJYAi2QrRwElGhQ7BCW9d3uxITtciTZ7ShqDqcmHEqL+RxOB8k0K6IEd0ooawMC 7Mkqtrhl2PLNq0yOx9owikSOgv0QNcIe4q3jhSilAlz6THQhFX0cAejiaEaHBo8D 18rqa8O3txkD2amcn5u9zoAE3xO5BiW3K6CMZ7GF1tJzAyfn3ErfDpHkwdCFmEsl lDpsHE+t4MWjzl/r7ZyMcAk14m8FMKVev/fyG9O7J8nUPhdYa3vPbWU1ATzRxnSj 5FzpcDwg8hh3G+42gaX4OSnYLhI8h2Gf2vZlE6BAdI/mldlxIJ6OZCCmTP34Btyf EXcB8pL2C7Gm0DcXdcY01fSWagnku/BgrRND+KILl75dl8U1QgPLUL2zRZ4SufSh 0HHO3VnctrwvuZecIbV4RmHHMoPKqhRxIFta4+HlrLzWXUPjLltua36uYooEG6TP s55eB5M/FWzyMtB9jsNEyncc4o8bCmIbIHc/eFpAaoG3PX7T3w1bbAvqEL1+UbHO HAbeVL6F6810Hml6CtxPf05UqsCOIVMDMzCNQbPV7nlkCgwuRzcEFyxUuan6B0ZY hnvfpRo5V5s8VooiSkwS =xSDz -----END PGP SIGNATURE----- --=-Q/xTCCNCCzfjRAu6Rn8i-- --===============7864037340163474320== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7864037340163474320==--