From: Dario Faggioli <dfaggioli@suse.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 1/2] xen: credit2: factor cpu to runqueue matching in a function
Date: Wed, 29 Apr 2020 19:36:30 +0200 [thread overview]
Message-ID: <158818178990.24327.6732870355943077303.stgit@Palanthas> (raw)
In-Reply-To: <158818022727.24327.14309662489731832234.stgit@Palanthas>
Just move the big if() condition in an inline function.
No functional change intended.
Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
---
xen/common/sched/credit2.c | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 34f05c3e2a..697c9f917d 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -838,6 +838,20 @@ static inline bool same_core(unsigned int cpua, unsigned int cpub)
cpu_to_core(cpua) == cpu_to_core(cpub);
}
+static inline bool
+cpu_runqueue_match(const struct csched2_runqueue_data *rqd, unsigned int cpu)
+{
+ unsigned int peer_cpu = rqd->pick_bias;
+
+ BUG_ON(cpu_to_socket(peer_cpu) == XEN_INVALID_SOCKET_ID);
+
+ /* OPT_RUNQUEUE_CPU will never find an existing runqueue. */
+ return opt_runqueue == OPT_RUNQUEUE_ALL ||
+ (opt_runqueue == OPT_RUNQUEUE_CORE && same_core(peer_cpu, cpu)) ||
+ (opt_runqueue == OPT_RUNQUEUE_SOCKET && same_socket(peer_cpu, cpu)) ||
+ (opt_runqueue == OPT_RUNQUEUE_NODE && same_node(peer_cpu, cpu));
+}
+
static struct csched2_runqueue_data *
cpu_add_to_runqueue(struct csched2_private *prv, unsigned int cpu)
{
@@ -855,21 +869,11 @@ cpu_add_to_runqueue(struct csched2_private *prv, unsigned int cpu)
rqd_ins = &prv->rql;
list_for_each_entry ( rqd, &prv->rql, rql )
{
- unsigned int peer_cpu;
-
/* Remember first unused queue index. */
if ( !rqi_unused && rqd->id > rqi )
rqi_unused = true;
- peer_cpu = rqd->pick_bias;
- BUG_ON(cpu_to_socket(cpu) == XEN_INVALID_SOCKET_ID ||
- cpu_to_socket(peer_cpu) == XEN_INVALID_SOCKET_ID);
-
- /* OPT_RUNQUEUE_CPU will never find an existing runqueue. */
- if ( opt_runqueue == OPT_RUNQUEUE_ALL ||
- (opt_runqueue == OPT_RUNQUEUE_CORE && same_core(peer_cpu, cpu)) ||
- (opt_runqueue == OPT_RUNQUEUE_SOCKET && same_socket(peer_cpu, cpu)) ||
- (opt_runqueue == OPT_RUNQUEUE_NODE && same_node(peer_cpu, cpu)) )
+ if ( cpu_runqueue_match(rqd, cpu) )
{
rqd_valid = true;
break;
@@ -3744,6 +3748,8 @@ csched2_alloc_pdata(const struct scheduler *ops, int cpu)
struct csched2_pcpu *spc;
struct csched2_runqueue_data *rqd;
+ BUG_ON(cpu_to_socket(cpu) == XEN_INVALID_SOCKET_ID);
+
spc = xzalloc(struct csched2_pcpu);
if ( spc == NULL )
return ERR_PTR(-ENOMEM);
next prev parent reply other threads:[~2020-04-29 17:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 17:36 [PATCH 0/2] xen: credit2: limit the number of CPUs per runqueue Dario Faggioli
2020-04-29 17:36 ` Dario Faggioli [this message]
2020-04-29 17:36 ` [PATCH 2/2] xen: credit2: limit the max number of CPUs in a runqueue Dario Faggioli
2020-04-30 6:45 ` Jan Beulich
2020-05-26 22:00 ` Dario Faggioli
2020-05-27 4:26 ` Jürgen Groß
2020-05-28 9:32 ` Dario Faggioli
2020-05-27 6:17 ` Jan Beulich
2020-05-28 14:55 ` Dario Faggioli
2020-05-29 9:58 ` Jan Beulich
2020-05-29 10:19 ` Dario Faggioli
2020-04-30 7:35 ` Jürgen Groß
2020-04-30 12:28 ` Dario Faggioli
2020-04-30 12:52 ` Jürgen Groß
2020-04-30 14:01 ` Dario Faggioli
2020-05-26 21:18 ` Dario Faggioli
2020-05-27 6:22 ` Jan Beulich
2020-05-28 9:36 ` Dario Faggioli
2020-05-29 11:46 ` [PATCH 0/2] xen: credit2: limit the number of CPUs per runqueue Dario Faggioli
2020-05-29 15:06 ` Dario Faggioli
2020-05-29 16:15 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158818178990.24327.6732870355943077303.stgit@Palanthas \
--to=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).