From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52049C4709C for ; Wed, 2 Jun 2021 15:18:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3BBB613D0 for ; Wed, 2 Jun 2021 15:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3BBB613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.136102.252534 (Exim 4.92) (envelope-from ) id 1loSde-0005IK-Uz; Wed, 02 Jun 2021 15:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 136102.252534; Wed, 02 Jun 2021 15:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loSde-0005ID-Rp; Wed, 02 Jun 2021 15:18:34 +0000 Received: by outflank-mailman (input) for mailman id 136102; Wed, 02 Jun 2021 15:18:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loSdd-0004jV-H3 for xen-devel@lists.xenproject.org; Wed, 02 Jun 2021 15:18:33 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39ac46a7-d29a-4f70-bd33-be027cf46735; Wed, 02 Jun 2021 15:18:30 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C01C221C5F; Wed, 2 Jun 2021 15:18:29 +0000 (UTC) Received: by imap.suse.de (Postfix, from userid 51) id B2F5111CD7; Wed, 2 Jun 2021 16:20:03 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 07E5611DEB; Wed, 2 Jun 2021 11:43:58 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id EbcnAP5ut2CmfQAALh3uQQ (envelope-from ); Wed, 02 Jun 2021 11:43:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39ac46a7-d29a-4f70-bd33-be027cf46735 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622647109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=87Kt1Qwerb8lFGsxIc5QBItlNhNqATSfokRkRwiOpRM=; b=VP96IW46WFnIQkZJLaZgVBzvMEf/AjlAYHJ+E3ku26f1kOCH8uPuDOZmxvi5pYAIxdcbOz PQ1dHwNii8GJ33jpXG/lY2k0zMIELPxHV3HlAxOgiJmb63XWWah9MMGiKAL+tAMpwbnwer a3++Pa/Luq4ov8rJRORYK2qcZ4cJZDw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622634238; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=87Kt1Qwerb8lFGsxIc5QBItlNhNqATSfokRkRwiOpRM=; b=C5upJA/vhU1vlJTcNQM7obcmeDvAuxojfCww+wcax2tvvxQ8dY6heRM0FBA+Soy+RdSquY jiBu1ajZiLYciXzXFaMxzX1Na8nFhYzwFE20mYC4SmChisUbbMNkvT4frDIWysdUbvo16J ZRq1+aG8yYXywiU7tuzu75DzePWyKXE= Subject: Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Anthony PERARD References: <20210601161118.18986-1-olaf@aepfle.de> <20210601161118.18986-3-olaf@aepfle.de> <58453bfc-d932-3b46-7ec8-cd883b4c7440@suse.com> <20210602124324.1bd02cd7.olaf@aepfle.de> From: Juergen Gross Message-ID: <158d6c27-7540-2b67-1104-4c0d99151dfa@suse.com> Date: Wed, 2 Jun 2021 13:43:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210602124324.1bd02cd7.olaf@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1N5wn9JjeVBn5ZBswJ7uuhN1gl1estidX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1N5wn9JjeVBn5ZBswJ7uuhN1gl1estidX Content-Type: multipart/mixed; boundary="FU1vaBaj48XrKc1mbYQxZiM3TzDtnPCy9"; protected-headers="v1" From: Juergen Gross To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Anthony PERARD Message-ID: <158d6c27-7540-2b67-1104-4c0d99151dfa@suse.com> Subject: Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug References: <20210601161118.18986-1-olaf@aepfle.de> <20210601161118.18986-3-olaf@aepfle.de> <58453bfc-d932-3b46-7ec8-cd883b4c7440@suse.com> <20210602124324.1bd02cd7.olaf@aepfle.de> In-Reply-To: <20210602124324.1bd02cd7.olaf@aepfle.de> --FU1vaBaj48XrKc1mbYQxZiM3TzDtnPCy9 Content-Type: multipart/mixed; boundary="------------A8ACBBBB03892156F3864B29" Content-Language: en-US This is a multi-part message in MIME format. --------------A8ACBBBB03892156F3864B29 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 02.06.21 12:43, Olaf Hering wrote: > Am Wed, 2 Jun 2021 08:09:00 +0200 > schrieb Juergen Gross : >=20 >>> - if ( ctx->save.debug && ctx->stream_type !=3D XC_STREAM_PLAIN ) >>> + if ( ctx->save.debug ) >> This is no documentation change IMO. You should either mention this >> modification in the commit message, or put it into a separate patch. >=20 > I think the conclusion was that this branch is dead code because > only the stream_type=3D=3DXC_STREAM_PLAIN code branch sets debug. >=20 >=20 > So far there is a decision to be made about this code branch: > - document it > - remove it > - fix it I don't mind either way. I just pointed out an inconsistency between patch title and content. When searching for a patch causing a regression I usually skip documentation patches. Juergen --------------A8ACBBBB03892156F3864B29 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A8ACBBBB03892156F3864B29-- --FU1vaBaj48XrKc1mbYQxZiM3TzDtnPCy9-- --1N5wn9JjeVBn5ZBswJ7uuhN1gl1estidX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmC3bv0FAwAAAAAACgkQsN6d1ii/Ey9k NAf+Iaf2MqF3zPsQYcHPdtBOQNzftjLqQKTWs47h2kz+rWh0heykOcb/MJSo4n3Sm93o/C0q7IHi hCgPxKfCBrf86rkSfRz9mBwDzr7qUsCbxaOInuAkpGJD9Rbp/eWyUxx54mvLYG9r48mWS7K59mnp CvKfSCeCyajlDdah7kx+V+hgFCzWDesYF8dNUwUmJjkQ3rCM6vCFbK03IYkpqbTPAxZr3r9X+FLV dBNaqbpXzYRJ0Gnfqk/cdt8/ldZ6z/DLvy0PepVYt1EniaeuS669KTgDEixgnL8Fz0E3/v4KvB18 V5tlEL12IoMxSG5q4nvIMUh09zNHXp24IgWwzQxLnQ== =J/Jx -----END PGP SIGNATURE----- --1N5wn9JjeVBn5ZBswJ7uuhN1gl1estidX--