From: Jan Beulich <JBeulich@suse.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v1] x86/mm: Clean IOMMU flags from p2m-pt code
Date: Mon, 1 Jul 2019 13:27:09 +0000 [thread overview]
Message-ID: <15db3f77-ba0f-4d42-bbea-30909d02b705@suse.com> (raw)
>>> On 18.06.19 at 13:54, <aisaila@bitdefender.com> wrote:
> At the moment the IOMMU flags are not used in p2m-pt and could be used
> on other application.
I don't understand the second half of this sentence. I guess anyway
that you want to at least mention the fact that CPU and IOMMU page
tables can't be shared anymore, ideally citing the commit that made
this impossible.
> This patch aims to clean the use of IOMMU flags on the AMD p2m side.
>
> Signed-off-by: Alexandru Isaila <aisaila@bitdefender.com>
> Suggested-by: George Dunlap <george.dunlap@citrix.com>
Nit: The natural order is the other way around, showing the flow
of events.
> @@ -36,13 +35,12 @@
> #include <asm/p2m.h>
> #include <asm/mem_sharing.h>
> #include <asm/hvm/nestedhvm.h>
> -#include <asm/hvm/svm/amd-iommu-proto.h>
>
> #include "mm-locks.h"
>
> /*
> * We may store INVALID_MFN in PTEs. We need to clip this to avoid trampling
> - * over higher-order bits (NX, p2m type, IOMMU flags). We seem to not need
> + * over higher-order bits (NX, p2m type). We seem to not need
> * to unclip on the read path, as callers are concerned only with p2m type in
> * such cases.
> */
Please re-flow the remainder of the comment.
> @@ -165,16 +163,6 @@ p2m_free_entry(struct p2m_domain *p2m, l1_pgentry_t
Below the previous but ahead of this hunk there's p2m_type_to_flags(),
which has a comment that looks to want adjustment (removal?) as well.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-07-01 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:27 Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-18 11:54 [Xen-devel] [PATCH v1] x86/mm: Clean IOMMU flags from p2m-pt code Alexandru Stefan ISAILA
2019-06-25 8:03 ` Alexandru Stefan ISAILA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15db3f77-ba0f-4d42-bbea-30909d02b705@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).