From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v4] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time
Date: Thu, 15 Apr 2021 11:27:46 +0200 [thread overview]
Message-ID: <164d8e67-fd65-9e98-53ef-51187310de0b@suse.com> (raw)
In-Reply-To: <d09b0690-c5e0-a90b-b4c0-4396a5f62c59@suse.com>
This combination doesn't really make sense (and there likely are more);
in particular even if the code built with both options set, HVM guests
wouldn't work (and I think one wouldn't be able to create one in the
first place). The alternative here would be some presumably intrusive
#ifdef-ary to get this combination to actually build (but still not
work) again.
Fixes: 8b5b49ceb3d9 ("x86: don't include domctl and alike in shim-exclusive builds")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---
v4: Default HVM to !PV_SHIM, as suggested by Jürgen.
v2: Restore lost default setting.
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -23,7 +23,7 @@ config X86
select HAS_PDX
select HAS_SCHED_GRANULARITY
select HAS_UBSAN
- select HAS_VPCI if !PV_SHIM_EXCLUSIVE && HVM
+ select HAS_VPCI if HVM
select NEEDS_LIBELF
select NUMA
@@ -90,9 +90,10 @@ config PV_LINEAR_PT
If unsure, say Y.
config HVM
- def_bool !PV_SHIM_EXCLUSIVE
+ bool "HVM support"
+ depends on !PV_SHIM_EXCLUSIVE
+ default !PV_SHIM
select IOREQ_SERVER
- prompt "HVM support"
---help---
Interfaces to support HVM domains. HVM domains require hardware
virtualisation extensions (e.g. Intel VT-x, AMD SVM), but can boot
next prev parent reply other threads:[~2021-04-15 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 8:42 [PATCH v3 0/3] x86: shim building adjustments (plus shadow follow-on) Jan Beulich
2020-10-19 8:44 ` [PATCH v3 1/3] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time Jan Beulich
2020-10-19 8:44 ` [PATCH v3 2/3] x86/shadow: refactor shadow_vram_{get,put}_l1e() Jan Beulich
2020-10-21 10:05 ` Roger Pau Monné
2020-10-29 20:15 ` Tim Deegan
2020-10-19 8:45 ` [PATCH v3 3/3] x86/shadow: sh_{make,destroy}_monitor_table() are "even more" HVM-only Jan Beulich
2020-10-21 10:45 ` Roger Pau Monné
2020-10-29 20:27 ` Tim Deegan
2020-10-29 13:40 ` Ping: [PATCH v3 0/3] x86: shim building adjustments (plus shadow follow-on) Jan Beulich
2020-10-29 20:53 ` Tim Deegan
2021-04-15 9:27 ` Jan Beulich [this message]
2021-04-27 16:08 ` Ping: [PATCH v4] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164d8e67-fd65-9e98-53ef-51187310de0b@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).