From: Paul Durrant <Paul.Durrant@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Date: Tue, 18 Jun 2019 07:55:53 +0000 [thread overview]
Message-ID: <17fc272d31cc4e95baa3ec68a90557d1@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20190617171913.GA15926@perard.uk.xensource.com>
> -----Original Message-----
> From: Anthony PERARD [mailto:anthony.perard@citrix.com]
> Sent: 17 June 2019 18:19
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini <sstabellini@kernel.org>; qemu-devel@nongnu.org
> Subject: Re: [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
>
> On Mon, Jun 17, 2019 at 05:45:44PM +0100, Anthony PERARD wrote:
> > On Mon, Jun 17, 2019 at 05:15:51PM +0100, Paul Durrant wrote:
> > > AFAICT the only place (apart from legacy code in xen_common.h) that
> > > params.h is necessary is in xen_suspend_notifier(). I wonder whether
> > > that would be better moved into xen_common.h too (since it's just a
> > > wrapper round xc_set_hvm_param() and then the inclusion of params.h
> > > can be moved there as well.
> >
> > :(, I didn't realised that xen_common.h needed params.h too. That patch
> > series might not build on older version of Xen. I'll move the inclusion
> > of params.h to xen_common.h, and fix params.h to have all the needed
> > #defines.
>
> Actually, it works fine without including hvm/params.h in xen_common.h
> because xen_common.h includes xenctrl.h which includes hvm/params.h.
>
> So I think instead I'll remove all includes of params.h, because
> HVM_PARAM_* are parameters for xc_hvm_param_{get,set}, which is in a
> library and not an interface with a guest. Including xenctrl.h should be
> enough.
The guest/tools separation is messy. ioreq.h is also an interface with Xen and not with a guest, so really I think it should be treated the same way as params.h. e820.h is referring to guest memory layout, which IMO shouldn't really be hardcoded at all.
Paul
>
> --
> Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-18 7:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 15:41 [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup Anthony PERARD
2019-06-17 15:41 ` [Xen-devel] [PATCH 1/4] xen: Fix build with public headers Anthony PERARD
2019-06-17 16:05 ` Paul Durrant
2019-06-17 15:41 ` [Xen-devel] [PATCH 2/4] xen: Import other xen/io/*.h Anthony PERARD
2019-06-17 16:09 ` Paul Durrant
2019-06-17 15:41 ` [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c Anthony PERARD
2019-06-17 16:15 ` Paul Durrant
2019-06-17 16:45 ` Anthony PERARD
2019-06-17 16:54 ` Paul Durrant
2019-06-17 17:19 ` Anthony PERARD
2019-06-18 7:55 ` Paul Durrant [this message]
2019-06-18 11:05 ` Anthony PERARD
2019-06-17 15:41 ` [Xen-devel] [PATCH 4/4] xen: Avoid VLA Anthony PERARD
2019-06-17 16:39 ` Paul Durrant
2019-06-17 17:36 ` Anthony PERARD
2019-06-18 7:50 ` Paul Durrant
2019-06-17 18:09 ` [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17fc272d31cc4e95baa3ec68a90557d1@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).