From: Luca Fancellu <luca.fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h
Date: Tue, 4 May 2021 14:09:09 +0100 [thread overview]
Message-ID: <1853929B-AC45-42AF-8FE4-7B23C700B2E2@arm.com> (raw)
In-Reply-To: <37e5b461-40fe-ac78-59b9-033ff8cdc6d1@suse.com>
> On 4 May 2021, at 12:48, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 04.05.2021 11:46, Luca Fancellu wrote:
>> @@ -451,11 +466,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t);
>> * bytes to be copied.
>> */
>>
>> -#define _GNTCOPY_source_gref (0)
>> -#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref)
>> -#define _GNTCOPY_dest_gref (1)
>> -#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref)
>> -
>> struct gnttab_copy {
>> /* IN parameters. */
>> struct gnttab_copy_ptr {
>> @@ -471,6 +481,12 @@ struct gnttab_copy {
>> /* OUT parameters. */
>> int16_t status;
>> };
>> +
>> +#define _GNTCOPY_source_gref (0)
>> +#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref)
>> +#define _GNTCOPY_dest_gref (1)
>> +#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref)
>
> Didn't you say you agree with moving this back up some, next to the
> field using these?
Hi Jan,
My mistake! I’ll move it in the next patch, did you spot anything else I might have forgot of what we agreed?
Cheers,
Luca
>
> Jan
next prev parent reply other threads:[~2021-05-04 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 9:46 [PATCH v4 0/3] Use Doxygen and sphinx for html documentation Luca Fancellu
2021-05-04 9:46 ` [PATCH v4 1/3] docs: add doxygen support " Luca Fancellu
2021-05-04 9:46 ` [PATCH v4 2/3] docs: hypercalls sphinx skeleton for generated html Luca Fancellu
2021-05-04 9:46 ` [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h Luca Fancellu
2021-05-04 11:48 ` Jan Beulich
2021-05-04 13:09 ` Luca Fancellu [this message]
2021-05-04 13:28 ` Jan Beulich
2021-05-04 13:33 ` Luca Fancellu
2021-05-04 16:14 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1853929B-AC45-42AF-8FE4-7B23C700B2E2@arm.com \
--to=luca.fancellu@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).