> On 15 Aug 2019, at 16:19, Wieczorkiewicz, Pawel wrote: > > Hi Lars, Julien, > > Thanks for the pointers, I will read them up and follow the recommendations with my future contributions. > Sorry for the mess… It's not really a mess: it must have been quite a pain to put the mails together manually And it would become more painful for a second revision I have been through this myself > But, let me ask first before reading the wikis, how do you prefer submitting series that contain patches belonging to 2 distinct repos (e.g. xen and livepatch-build-tools)? That's a good question and a very rare use-case. We split them, as all the tools such as git format-patch only work on one repo Applying patches also only works on a per repo basis So, I would send two series. But mention the relationship in the cover letter (and/or patch if it is a single one) The tools in the docs currently may not work on livepatch-build-tools.git * First: there is no MAINTAINERS file in livepatch-build-tools.git, which really should be added * Second: using xen.git:/scripts/add_maintainers.pl may not work when called from within livepatch-build-tools.git I am going to play with this and update the docs and if needed the tools accordingly You may have to improvise in the meantime: * Step 1 & 3 will work: Step 2, option 1 will probably not (which means until I have done this, you may have to follow option 2 and make sure that the right people are CC'ed) You can also use: https://patchew.org/Xen/ , https://patchwork.kernel.org/project/xen-devel/list/ or https://lore.kernel.org/xen-devel/ to track some of the changes. I have not had time to add this to the docs yet Lars > > Best Regards, > Pawel Wieczorkiewicz > > > >> On 15. Aug 2019, at 16:58, Lars Kurth > wrote: >> >> >> >>> On 15 Aug 2019, at 12:38, Julien Grall > wrote: >>> >>> Hi, >>> >>> I am not going to answer on the patch itself but the process. >>> >>> Any series (i.e more than one patch) should contain a cover letter with a rough summary of the goal of the series. >>> >>> Furthermore, this 3 patches series has been received as 3 separate threads (i.e in-reply-to is missing). This is making difficult to know that all the patches belongs to the same series. In general, all patches are send as in-reply-to the cover letter. So all the patches sticks together in one thread. >>> >>> The cover letter can be generated via git format-patch --cover-letter. Threading is done automatically with git-send-email when all the patches as passed in arguments. >>> >>> For more details how to do it, you can read: >>> >>> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series >>> >>> Cheers, >> >> Hi Pawel, >> >> thank you for submitting the patch series. >> >> We had a couple of new starters recently who followed a similar pattern to you. As a result of this, I recently updated the following docs >> >> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches - Definitions and general workflow >> The bit which saves the most work is https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series >> As for Julien's comment on the threading: see the --thread and --cover-letter option as described in the Sending a Patch Series >> >> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git - Basic Git commands fitting into the workflow, including how to deal with reviews >> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit - Basic StGit commands fitting into the workflow, including how to deal with reviews >> I have not had time to play with git series yet. If anyone in your team uses it let me know >> >> In any case: if you follow the instructions the entire submission process and dealing with review comments becomes much easier. >> >> As a newcomer, to contributing to Xen, I would greatly appreciate if you could let me know of any issues with the docs, such that we can fix them >> >> Regards >> Lars >> >> >> > > > > > Amazon Development Center Germany GmbH > Krausenstr. 38 > 10117 Berlin > Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich > Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B > Sitz: Berlin > Ust-ID: DE 289 237 879 > >