From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675CAC3A589 for ; Thu, 15 Aug 2019 15:33:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2988E20644 for ; Thu, 15 Aug 2019 15:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eceirhu6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2988E20644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyHky-0002vN-7w; Thu, 15 Aug 2019 15:33:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyHkw-0002v6-Ux for xen-devel@lists.xen.org; Thu, 15 Aug 2019 15:33:39 +0000 X-Inumbo-ID: 0ca3beec-bf72-11e9-b90c-bc764e2007e4 Received: from mail-wr1-x443.google.com (unknown [2a00:1450:4864:20::443]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0ca3beec-bf72-11e9-b90c-bc764e2007e4; Thu, 15 Aug 2019 15:33:37 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id s18so1822915wrn.1 for ; Thu, 15 Aug 2019 08:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=BgMb6kuCtA2+6OKaC6dRpzpEPePkMR9cM8ZszLs3Zok=; b=eceirhu6hcpIQFLIUfDS4bEYcZuv/RYr1I5GUoMlFrt2c8uMxNGYmAfhgtW7Uyjkn3 51nqLlnfWvECqrV68vKsIjMVUKHtSoQ2djpPGduzJHc0MIslYDpZywvnqQvhTJgEHMcE cDPPTe5I+oHKdCnEkbyOMK2lsGE4CloTJFhUzaPNY0gc63UHvrZd/HbSPCvzrAZU3+PF tVghM8Alw+zqcrd+C7oimLmBD2Typg5yCG4VnunA9436FJ5HgcPi7c2FYngVmEGLFimJ It0GqlzFLjv9gq4E63xzNMF791xQ8l9Xo0yB531AyHWZBhkvmcLMf2Lk0MM3f6cDatnM +0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=BgMb6kuCtA2+6OKaC6dRpzpEPePkMR9cM8ZszLs3Zok=; b=TepJYMDn7dMVV997RlGus2Mjja15MhlkY7MoZqH2GnpMIHluqs5OV2/yBPQXgyTviq zAApQBFQDX9++jioyc/0e9P4FgVrFXgJ2Ls2BfQLaZOimb8KzZK1T/nVb7lHYA/1SP+f YdnjzGkFYBvCuaRKH7RtN3xMhczvz0E7d8zKroWNOfdR2sT5ymix3XXoagBa2Nk61Gsy 5/2ssy1Y30P+D7QSsqFc1879pTGwxaShIU+uZRUgSf2lmdLUBGj7B3yLmIuFov4EeHRg Du7MRs7U2YYdigCJHjcntGsLAsUi2x2pZzoaAhr3brXtf1uv7GvmRGBcMBnhhLEBHjJq g9GQ== X-Gm-Message-State: APjAAAXvOR1mgHVADZmYbvOv7GuwmglPa8gT7lQbhM6fMR9JQQnFoKdu HcK1X1FdlFI6PeRgmapuKmE= X-Google-Smtp-Source: APXvYqwUWn9yqTCg/cu5KsQ7SytNx+fOlaSog+MqKtYeuVsvxwfpHQv4SPKm+cUERaQRYhKJGSKZzg== X-Received: by 2002:adf:82d4:: with SMTP id 78mr5666355wrc.85.1565883216060; Thu, 15 Aug 2019 08:33:36 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ac18:da00:401e:f277:3894:a225? ([2a02:c7f:ac18:da00:401e:f277:3894:a225]) by smtp.gmail.com with ESMTPSA id w5sm1828674wmm.43.2019.08.15.08.33.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Aug 2019 08:33:35 -0700 (PDT) From: Lars Kurth Message-Id: <18CBBC37-9027-41B7-8375-44FE3E56F79F@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Thu, 15 Aug 2019 16:33:34 +0100 In-Reply-To: To: "Wieczorkiewicz, Pawel" References: <20190815112708.11474-1-wipawel@amazon.de> <8d5350af-2ca8-a651-c43c-07372779322d@arm.com> <3E431F27-7D89-4CE8-8FBA-86A38EBA580F@xenproject.org> X-Mailer: Apple Mail (2.3445.104.11) Subject: Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "Tim \(Xen.org\)" , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel , "Pohlack, Martin" , Ross Lagerwall , Julien Grall , 'Jan Beulich' , xen-devel Content-Type: multipart/mixed; boundary="===============4589688821352873947==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============4589688821352873947== Content-Type: multipart/alternative; boundary="Apple-Mail=_9A1AFB74-CC39-4993-B300-774065B6539E" --Apple-Mail=_9A1AFB74-CC39-4993-B300-774065B6539E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 15 Aug 2019, at 16:19, Wieczorkiewicz, Pawel = wrote: >=20 > Hi Lars, Julien, >=20 > Thanks for the pointers, I will read them up and follow the = recommendations with my future contributions. > Sorry for the mess=E2=80=A6 It's not really a mess: it must have been quite a pain to put the mails = together manually And it would become more painful for a second revision I have been through this myself > But, let me ask first before reading the wikis, how do you prefer = submitting series that contain patches belonging to 2 distinct repos = (e.g. xen and livepatch-build-tools)? That's a good question and a very rare use-case. We split them, as all = the tools such as git format-patch only work on one repo Applying patches also only works on a per repo basis So, I would send two series. But mention the relationship in the cover = letter (and/or patch if it is a single one) The tools in the docs currently may not work on = livepatch-build-tools.git * First: there is no MAINTAINERS file in livepatch-build-tools.git, = which really should be added * Second: using xen.git:/scripts/add_maintainers.pl may not work when = called from within livepatch-build-tools.git I am going to play with this and update the docs and if needed the tools = accordingly You may have to improvise in the meantime: * Step 1 & 3 will work: Step 2, option 1 will probably not (which means = until I have done this, you may have to follow option 2 and make sure = that the right people are CC'ed) You can also use: https://patchew.org/Xen/ , = https://patchwork.kernel.org/project/xen-devel/list/ = or = https://lore.kernel.org/xen-devel/ = to track some of the changes. I have not had time to add this to the = docs yet Lars >=20 > Best Regards, > Pawel Wieczorkiewicz >=20 >=20 >=20 >> On 15. Aug 2019, at 16:58, Lars Kurth > wrote: >>=20 >>=20 >>=20 >>> On 15 Aug 2019, at 12:38, Julien Grall > wrote: >>>=20 >>> Hi, >>>=20 >>> I am not going to answer on the patch itself but the process. >>>=20 >>> Any series (i.e more than one patch) should contain a cover letter = with a rough summary of the goal of the series. >>>=20 >>> Furthermore, this 3 patches series has been received as 3 separate = threads (i.e in-reply-to is missing). This is making difficult to know = that all the patches belongs to the same series. In general, all patches = are send as in-reply-to the cover letter. So all the patches sticks = together in one thread. >>>=20 >>> The cover letter can be generated via git format-patch = --cover-letter. Threading is done automatically with git-send-email when = all the patches as passed in arguments. >>>=20 >>> For more details how to do it, you can read: >>>=20 >>> = https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_= Patch_Series = >>>=20 >>> Cheers, >>=20 >> Hi Pawel,=20 >>=20 >> thank you for submitting the patch series.=20 >>=20 >> We had a couple of new starters recently who followed a similar = pattern to you. As a result of this, I recently updated the following = docs >>=20 >> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches = - = Definitions and general workflow >> The bit which saves the most work is = https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_= Patch_Series = >> As for Julien's comment on the threading: see the --thread and = --cover-letter option as described in the Sending a Patch Series >>=20 >> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git = - Basic = Git commands fitting into the workflow, including how to deal with = reviews >> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit = - = Basic StGit commands fitting into the workflow, including how to deal = with reviews >> I have not had time to play with git series yet. If anyone in your = team uses it let me know >>=20 >> In any case: if you follow the instructions the entire submission = process and dealing with review comments becomes much easier.=20 >>=20 >> As a newcomer, to contributing to Xen, I would greatly appreciate if = you could let me know of any issues with the docs, such that we can fix = them >>=20 >> Regards >> Lars >>=20 >>=20 >>=20 >=20 >=20 >=20 >=20 > Amazon Development Center Germany GmbH=20 > Krausenstr. 38=20 > 10117 Berlin=20 > Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich=20 > Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B=20 > Sitz: Berlin=20 > Ust-ID: DE 289 237 879=20 >=20 >=20 --Apple-Mail=_9A1AFB74-CC39-4993-B300-774065B6539E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 15 Aug 2019, at 16:19, Wieczorkiewicz, Pawel <wipawel@amazon.de> = wrote:

Hi Lars, Julien,

Thanks for the pointers, I will read them up and follow = the recommendations with my future contributions.
Sorry for the = mess=E2=80=A6

It's not really a mess: it must have been quite a = pain to put the mails together manually
And it would become = more painful for a second revision
I have been through this = myself

But, let me ask first before reading the wikis, how do = you prefer submitting series that contain patches belonging to 2 = distinct repos (e.g. xen and = livepatch-build-tools)?

That's a good question and a very rare use-case. We = split them, as all the tools such as git format-patch only work on = one repo
Applying patches also only works on a per repo = basis

So, I would send two series. = But mention the relationship in the cover letter (and/or patch if it is = a single one)

The tools in the docs = currently may not work on livepatch-build-tools.git
* First: = there is no MAINTAINERS file in livepatch-build-tools.git, which really = should be added
* Second: using = xen.git:/scripts/add_maintainers.pl may not work when called from within = livepatch-build-tools.git

I am going = to play with this and update the docs and if needed the tools = accordingly
You may have to improvise in the = meantime:
* Step 1 & 3 will work: Step 2, option 1 will = probably not (which means until I have done this, you may have to follow = option 2 and make sure that the right people are CC'ed)

You can also use: https://patchew.org/Xen/https://patchwork.kernel.org/project/xen-devel/list/ o= r https://lore.kernel.org/xen-devel/ to track some of = the changes. I have not had time to add this to the docs = yet

Lars


Best Regards,
Pawel Wieczorkiewicz



On 15. Aug 2019, at 16:58, Lars Kurth <lars.kurth.xen@gmail.com> wrote:



On 15 Aug 2019, at 12:38, Julien Grall <julien.grall@arm.com> wrote:

Hi,

I am not going to answer on the patch itself but the process.

Any series (i.e more than one patch) should contain a cover letter with a = rough summary of the goal of the series.

Furthermore, this 3 patches series has been received as 3 separate threads (i.e = in-reply-to is missing). This is making difficult to know that all the = patches belongs to the same series. In general, all patches are send as = in-reply-to the cover letter. So all the patches sticks together in one thread.

The cover letter can be generated via git format-patch --cover-letter. = Threading is done automatically with git-send-email when all the patches = as passed in arguments.

For more details how to do it, you can read:

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches= #Sending_a_Patch_Series

Cheers,

Hi Pawel, 

thank you for submitting the patch series. 

We had a couple of new starters recently who followed a = similar pattern to you. As a result of this, I recently updated the = following docs

As for Julien's comment on the threading: see = the --thread and --cover-letter option as described in the Sending = a Patch Series

https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGi= t - Basic StGit commands fitting into the workflow, including = how to deal with reviews
I have not had time to play with git series yet. If = anyone in your team uses it let me know

In any case: if you follow the instructions the entire = submission process and dealing with review comments becomes much = easier. 

As a newcomer, to contributing to Xen, I would greatly = appreciate if you could let me know of any issues with the docs, such = that we can fix them

Regards
Lars







Amazon Development Center = Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB = 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879



= --Apple-Mail=_9A1AFB74-CC39-4993-B300-774065B6539E-- --===============4589688821352873947== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4589688821352873947==--