From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Ian Jackson" <Ian.Jackson@citrix.com>,
"Anthony PERARD" <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 6/6] xen/public: Obsolete HVM_PARAM_PAE_ENABLED
Date: Thu, 6 Feb 2020 12:37:36 +0100 [thread overview]
Message-ID: <18fa5048-0fc7-c60d-bf93-d02442bae70d@suse.com> (raw)
In-Reply-To: <5227980e-5938-f23b-7b1d-eac67bba792e@citrix.com>
On 06.02.2020 12:32, Andrew Cooper wrote:
> On 06/02/2020 09:28, Jan Beulich wrote:
>> On 05.02.2020 17:50, Andrew Cooper wrote:
>>> --- a/xen/include/public/hvm/params.h
>>> +++ b/xen/include/public/hvm/params.h
>>> @@ -86,7 +86,7 @@
>>> #define HVM_PARAM_STORE_PFN 1
>>> #define HVM_PARAM_STORE_EVTCHN 2
>>>
>>> -#define HVM_PARAM_PAE_ENABLED 4
>>> +#define HVM_PARAM_PAE_ENABLED 4 /* Obsolete. Do not use. */
>> I think this should be moved up in the deprecated section.
>
> There isn't a deprecated section.
>
> The params are currently sorted numerically. Playing "which param is
> this integer?" with an unsorted params.h is an experience I wish never
> to repeat again.
You'll find
/* These parameters are deprecated and their meaning is undefined. */
near the top of the file. I can see your concern about the file not
being sorted, but it already isn't. The alternative then is to frame
each deprecated param by #ifdef __XEN__ - I'd be okay with that if
that's preferred by you.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-06 11:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:50 [Xen-devel] [PATCH 0/6] tools: Rationalise legacy CPUID handling Andrew Cooper
2020-02-05 16:50 ` [Xen-devel] [PATCH 1/6] tools/libxl: Remove libxl_cpuid_{set, apply_policy}() from the API Andrew Cooper
2020-02-11 17:40 ` Ian Jackson
2020-02-05 16:50 ` [Xen-devel] [PATCH 2/6] tools/ocaml: Drop cpuid helpers Andrew Cooper
2020-02-06 14:25 ` Christian Lindig
2020-02-05 16:50 ` [Xen-devel] [PATCH 3/6] tools/python: " Andrew Cooper
2020-02-05 19:37 ` Marek Marczykowski-Górecki
2020-02-11 17:41 ` Ian Jackson
2020-02-05 16:50 ` [Xen-devel] [PATCH 4/6] tools/libxl: Combine legacy CPUID handling logic Andrew Cooper
2020-02-11 17:43 ` Ian Jackson
2020-02-05 16:50 ` [Xen-devel] [PATCH 5/6] tools/libx[cl]: Don't use HVM_PARAM_PAE_ENABLED as a function parameter Andrew Cooper
2020-02-11 17:47 ` Ian Jackson
2020-02-11 17:55 ` Andrew Cooper
2020-02-17 15:40 ` Ian Jackson
2020-02-17 17:57 ` [Xen-devel] [PATCH v2 " Andrew Cooper
2020-02-17 17:59 ` Ian Jackson
2020-02-05 16:50 ` [Xen-devel] [PATCH 6/6] xen/public: Obsolete HVM_PARAM_PAE_ENABLED Andrew Cooper
2020-02-06 9:28 ` Jan Beulich
2020-02-06 11:32 ` Andrew Cooper
2020-02-06 11:37 ` Jan Beulich [this message]
2020-02-06 12:25 ` Andrew Cooper
2020-02-08 12:12 ` Julien Grall
2020-02-08 12:15 ` Andrew Cooper
2020-02-11 17:49 ` Ian Jackson
2020-02-11 18:03 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18fa5048-0fc7-c60d-bf93-d02442bae70d@suse.com \
--to=jbeulich@suse.com \
--cc=Ian.Jackson@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).