From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Jason Andryuk <jandryuk@gmail.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>, QEMU <qemu-devel@nongnu.org>,
Claudio Fontana <cfontana@suse.de>,
Anthony Perard <anthony.perard@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 0/3] Add Xen CpusAccel
Date: Fri, 23 Oct 2020 09:09:47 +0200 [thread overview]
Message-ID: <1927b32e-7919-5061-0285-d9c7184d0bae@redhat.com> (raw)
In-Reply-To: <d9f23eee-c0af-d2dd-9b9d-f0255fc8e3d1@redhat.com>
On 22/10/2020 17.29, Paolo Bonzini wrote:
> On 22/10/20 17:17, Jason Andryuk wrote:
>> On Tue, Oct 13, 2020 at 1:16 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>
>>> On 13/10/20 16:05, Jason Andryuk wrote:
>>>> Xen was left behind when CpusAccel became mandatory and fails the assert
>>>> in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
>>>> Move the qtest cpu functions to a common location and reuse them for
>>>> Xen.
>>>>
>>>> v2:
>>>> New patch "accel: Remove _WIN32 ifdef from qtest-cpus.c"
>>>> Use accel/dummy-cpus.c for filename
>>>> Put prototype in include/sysemu/cpus.h
>>>>
>>>> Jason Andryuk (3):
>>>> accel: Remove _WIN32 ifdef from qtest-cpus.c
>>>> accel: move qtest CpusAccel functions to a common location
>>>> accel: Add xen CpusAccel using dummy-cpus
>>>>
>>>> accel/{qtest/qtest-cpus.c => dummy-cpus.c} | 27 ++++------------------
>>>> accel/meson.build | 8 +++++++
>>>> accel/qtest/meson.build | 1 -
>>>> accel/qtest/qtest-cpus.h | 17 --------------
>>>> accel/qtest/qtest.c | 5 +++-
>>>> accel/xen/xen-all.c | 8 +++++++
>>>> include/sysemu/cpus.h | 3 +++
>>>> 7 files changed, 27 insertions(+), 42 deletions(-)
>>>> rename accel/{qtest/qtest-cpus.c => dummy-cpus.c} (71%)
>>>> delete mode 100644 accel/qtest/qtest-cpus.h
>>>>
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thank you, Paolo. Also Anthony Acked and Claudio Reviewed patch 3.
>> How can we get this into the tree?
>
> I think Anthony should send a pull request?
Since Anthony acked patch 3, I think I can also take it through the qtest tree.
Thomas
next prev parent reply other threads:[~2020-10-23 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:05 [PATCH v2 0/3] Add Xen CpusAccel Jason Andryuk
2020-10-13 14:05 ` [PATCH v2 3/3] accel: Add xen CpusAccel using dummy-cpus Jason Andryuk
2020-10-13 14:12 ` Claudio Fontana
2020-10-16 15:05 ` Anthony PERARD
2020-10-13 17:16 ` [PATCH v2 0/3] Add Xen CpusAccel Paolo Bonzini
2020-10-22 15:17 ` Jason Andryuk
2020-10-22 15:29 ` Paolo Bonzini
2020-10-23 7:09 ` Thomas Huth [this message]
2020-10-23 9:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1927b32e-7919-5061-0285-d9c7184d0bae@redhat.com \
--to=thuth@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=cfontana@suse.de \
--cc=jandryuk@gmail.com \
--cc=lvivier@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).