From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 1/6] xen/x86: Provide helpers for common code to access acpi_numa
Date: Thu, 29 Sep 2022 14:29:30 +0800 [thread overview]
Message-ID: <1b2c0122-19d0-1478-0b51-6cb685a5273b@arm.com> (raw)
In-Reply-To: <5547335f-9e01-d461-f866-c0f823aa2814@suse.com>
Hi Jan,
On 2022/9/27 15:37, Jan Beulich wrote:
> On 20.09.2022 11:12, Wei Chen wrote:
>> --- a/xen/arch/x86/numa.c
>> +++ b/xen/arch/x86/numa.c
>> @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
>> bool numa_off;
>> s8 acpi_numa = 0;
>>
>> -int srat_disabled(void)
>> +int __init arch_numa_setup(const char *opt)
>> {
>> - return numa_off || acpi_numa < 0;
>> +#ifdef CONFIG_ACPI_NUMA
>> + if ( !strncmp(opt, "noacpi", 6) )
>> + {
>> + numa_off = false;
>> + acpi_numa = -1;
>
> When making the v5 changes, did you go over the results to check they are
> actually consistent? I'm afraid they still aren't, because of the line
> above: Here we disable NUMA, but that doesn't mean there's broken firmware.
Yes, you're right. I had not realized it while I was modifying this patch.
> Therefore I guess I need to ask for another round of renaming of the two
> helper functions; I'm sorry for that. What you introduce ...
>
>> + return 0;
>> + }
>> +#endif
>> +
>> + return -EINVAL;
>> +}
>> +
>> +bool arch_numa_broken(void)
>> +{
>> + return acpi_numa < 0;
>> +}
>
> ... here wants to be arch_numa_disabled(), whereas the function currently
> named this way (in patch 5) wants to be e.g. arch_numa_unavailable() (or,
> using inverted sense, arch_numa_available()). Of course I'll be happy to
> see other naming suggestions for both functions, as long as they reflect
> the respective purposes.
>
> Alternatively, to retain the current naming, the assignments to acpi_numa
> would need revising. But I think that would be the more fragile approach.
>
Yes, I agree with you, I will rename these two functions. Your suggested
names are reasonable, I will use them in next version.
Cheers,
Wei Chen
> Jan
next prev parent reply other threads:[~2022-09-29 6:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:12 [PATCH v5 0/6] Device tree based NUMA support for Arm - Part#2 Wei Chen
2022-09-20 9:12 ` [PATCH v5 1/6] xen/x86: Provide helpers for common code to access acpi_numa Wei Chen
2022-09-27 7:37 ` Jan Beulich
2022-09-29 6:29 ` Wei Chen [this message]
2022-09-20 9:12 ` [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Wei Chen
2022-09-27 8:19 ` Jan Beulich
2022-09-27 9:39 ` Jan Beulich
2022-09-29 7:58 ` Wei Chen
2022-09-29 7:43 ` Wei Chen
2022-09-29 12:14 ` Jan Beulich
2022-09-30 1:45 ` Wei Chen
2022-09-20 9:12 ` [PATCH v5 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Wei Chen
2022-09-20 9:12 ` [PATCH v5 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Wei Chen
2022-09-20 9:12 ` [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Wei Chen
2022-09-27 15:48 ` Jan Beulich
2022-09-29 8:21 ` Wei Chen
2022-09-29 12:21 ` Jan Beulich
2022-09-30 1:40 ` Wei Chen
2022-09-30 6:03 ` Jan Beulich
2022-10-09 7:25 ` Wei Chen
2022-10-10 7:03 ` Wei Chen
2022-10-10 8:25 ` Jan Beulich
2022-09-20 9:12 ` [PATCH v5 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Wei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b2c0122-19d0-1478-0b51-6cb685a5273b@arm.com \
--to=wei.chen@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=nd@arm.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).