From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33254C433E0 for ; Fri, 19 Feb 2021 14:16:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D21E664E46 for ; Fri, 19 Feb 2021 14:16:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D21E664E46 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.86890.163417 (Exim 4.92) (envelope-from ) id 1lD6ZX-00014X-3A; Fri, 19 Feb 2021 14:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 86890.163417; Fri, 19 Feb 2021 14:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lD6ZW-00014Q-WE; Fri, 19 Feb 2021 14:15:55 +0000 Received: by outflank-mailman (input) for mailman id 86890; Fri, 19 Feb 2021 14:15:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lD6ZW-00014L-1s for xen-devel@lists.xenproject.org; Fri, 19 Feb 2021 14:15:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9b8a634b-4203-446c-912f-84de8b4f57a6; Fri, 19 Feb 2021 14:15:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14FCEABAE; Fri, 19 Feb 2021 14:15:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b8a634b-4203-446c-912f-84de8b4f57a6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613744152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Ycka/xTMYs/DV3CnJFaLl8REG1O2rk4dF5PdWYzoWY=; b=jsGEjuLgR/i3+6meOJ7tMesy8/9vVPGiOTIbJCgpbf5z1o8ck2eSJq53wEgRrMtKZv2HFk 7sjC30Z/a4PB+ixi1l6yfQlAbHKQdc4vhlwlPhIQtnQXwsc6xDQ0LVnIH0RzoH5QQ7Xj3h 40jYj0v/6VgjItZhPWrRyNivpQPvECA= Subject: Re: [PATCH-for-4.15] tools/libs/light: fix xl save -c handling To: Juergen Gross Cc: Ian Jackson , Wei Liu , Anthony PERARD , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <20210219141337.6934-1-jgross@suse.com> From: Jan Beulich Message-ID: <1c02c3af-0a9b-6c68-e110-9d0963275e17@suse.com> Date: Fri, 19 Feb 2021 15:15:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219141337.6934-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 19.02.2021 15:13, Juergen Gross wrote: > libxl_domain_resume() won't work correctly for the case it was called > due to a "xl save -c" command, i.e. to continue the suspended domain. > > The information to do that is not saved in libxl__dm_resume_state for > non-HVM domains. > > Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume") > Reported-by: Marek Marczykowski-Górecki > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich