From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB17BC43331 for ; Wed, 25 Mar 2020 11:47:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B67D620714 for ; Wed, 25 Mar 2020 11:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B67D620714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH4Ui-00029m-Oq; Wed, 25 Mar 2020 11:46:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH4Ug-00029g-Ti for xen-devel@lists.xenproject.org; Wed, 25 Mar 2020 11:46:46 +0000 X-Inumbo-ID: 4dcc1786-6e8e-11ea-bec1-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4dcc1786-6e8e-11ea-bec1-bc764e2007e4; Wed, 25 Mar 2020 11:46:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 834F5AC5B; Wed, 25 Mar 2020 11:46:45 +0000 (UTC) To: paul@xen.org References: <6fa81b4d-528d-5c33-50c5-a18396b4383a@suse.com> <81e7aade-9dfb-313a-ad81-30b2703c2136@suse.com> <00c301d60297$471cb7f0$d55627d0$@xen.org> From: Jan Beulich Message-ID: <1cc4b223-42c4-1c3b-98fb-d43cda1c47bf@suse.com> Date: Wed, 25 Mar 2020 12:46:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <00c301d60297$471cb7f0$d55627d0$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH v5 05/10] x86emul: support MOVDIR64B insn X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, 'Paul Durrant' , 'Roger Pau Monne' , 'Wei Liu' , 'Andrew Cooper' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 25.03.2020 12:19, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel On Behalf Of Jan Beulich >> Sent: 24 March 2020 12:34 >> To: xen-devel@lists.xenproject.org >> Cc: Andrew Cooper ; Paul Durrant ; Wei Liu >> ; Roger Pau Monne >> Subject: [Xen-devel] [PATCH v5 05/10] x86emul: support MOVDIR64B insn >> >> Introduce a new blk() hook, paralleling the rmw() on in certain way, but >> being intended for larger data sizes, and hence its HVM intermediate >> handling function doesn't fall back to splitting the operation if the >> requested virtual address can't be mapped. >> >> Note that SDM revision 071 doesn't specify exception behavior for >> ModRM.mod == 0b11; assuming #UD here. >> >> Signed-off-by: Jan Beulich >> --- >> TBD: If we want to avoid depending on correct MTRR settings, >> hvmemul_map_linear_addr() may need to gain a parameter to allow >> controlling cachability of the produced mapping(s). > > Or could we deal with this by adding an optional cache flush into the unmap? But (non-)cachability of a range can't generally by covered by simply flushing the cache. >> Of course the >> function will also need to be made capable of mapping at least >> p2m_mmio_direct pages for this and the two ENQCMD insns to be >> actually useful. > > > I/O emulation parts LGTM so... > > Reviewed-by: Paul Durrant Thanks much. Jan