* [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
@ 2019-09-30 10:34 Oleksandr Tyshchenko
2019-09-30 10:35 ` Paul Durrant
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Oleksandr Tyshchenko @ 2019-09-30 10:34 UTC (permalink / raw)
To: xen-devel
Cc: jgross, sstabellini, Oleksandr Tyshchenko, julien.grall,
paul.durrant, volodymyr_babchuk
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
The Arm realization should have been removed in the following commit
as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables
So, remove unused function completely.
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
xen/drivers/passthrough/arm/iommu.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
index 76e1152..db3b07a 100644
--- a/xen/drivers/passthrough/arm/iommu.c
+++ b/xen/drivers/passthrough/arm/iommu.c
@@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
{
}
-int arch_iommu_populate_page_table(struct domain *d)
-{
- /* The IOMMU shares the p2m with the CPU */
- return -ENOSYS;
-}
-
void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
{
}
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-09-30 10:34 [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely Oleksandr Tyshchenko
@ 2019-09-30 10:35 ` Paul Durrant
2019-09-30 10:42 ` Julien Grall
2019-09-30 10:44 ` Jürgen Groß
2 siblings, 0 replies; 7+ messages in thread
From: Paul Durrant @ 2019-09-30 10:35 UTC (permalink / raw)
To: 'Oleksandr Tyshchenko', xen-devel
Cc: jgross, Oleksandr Tyshchenko, julien.grall, sstabellini,
volodymyr_babchuk
> -----Original Message-----
> From: Oleksandr Tyshchenko <olekstysh@gmail.com>
> Sent: 30 September 2019 11:35
> To: xen-devel@lists.xenproject.org
> Cc: julien.grall@arm.com; sstabellini@kernel.org; volodymyr_babchuk@epam.com; jgross@suse.com; Paul
> Durrant <Paul.Durrant@citrix.com>; Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Subject: [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
>
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
>
> So, remove unused function completely.
Good catch.
Reviewed-by: Paul Durrant <paul@xen.org>
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> xen/drivers/passthrough/arm/iommu.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
> index 76e1152..db3b07a 100644
> --- a/xen/drivers/passthrough/arm/iommu.c
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
> {
> }
>
> -int arch_iommu_populate_page_table(struct domain *d)
> -{
> - /* The IOMMU shares the p2m with the CPU */
> - return -ENOSYS;
> -}
> -
> void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
> {
> }
> --
> 2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-09-30 10:34 [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely Oleksandr Tyshchenko
2019-09-30 10:35 ` Paul Durrant
@ 2019-09-30 10:42 ` Julien Grall
2019-09-30 10:44 ` Jürgen Groß
2 siblings, 0 replies; 7+ messages in thread
From: Julien Grall @ 2019-09-30 10:42 UTC (permalink / raw)
To: Oleksandr Tyshchenko, xen-devel
Cc: jgross, Oleksandr Tyshchenko, sstabellini, volodymyr_babchuk,
paul.durrant
Hi Oleksandr,
On 30/09/2019 11:34, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
>
> So, remove unused function completely.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Acked-by: Julien Grall <julien.grall@arm.com>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-09-30 10:34 [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely Oleksandr Tyshchenko
2019-09-30 10:35 ` Paul Durrant
2019-09-30 10:42 ` Julien Grall
@ 2019-09-30 10:44 ` Jürgen Groß
2019-09-30 11:05 ` Oleksandr
2 siblings, 1 reply; 7+ messages in thread
From: Jürgen Groß @ 2019-09-30 10:44 UTC (permalink / raw)
To: Oleksandr Tyshchenko, xen-devel
Cc: Oleksandr Tyshchenko, julien.grall, paul.durrant,
volodymyr_babchuk, sstabellini
On 30.09.19 12:34, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
>
> So, remove unused function completely.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-09-30 10:44 ` Jürgen Groß
@ 2019-09-30 11:05 ` Oleksandr
2019-10-08 17:21 ` Oleksandr
0 siblings, 1 reply; 7+ messages in thread
From: Oleksandr @ 2019-09-30 11:05 UTC (permalink / raw)
To: Jürgen Groß, xen-devel
Cc: Oleksandr Tyshchenko, julien.grall, paul.durrant,
volodymyr_babchuk, sstabellini
Hi
On 30.09.19 13:44, Jürgen Groß wrote:
> On 30.09.19 12:34, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The Arm realization should have been removed in the following commit
>> as redundant:
>> f89f555 remove late (on-demand) construction of IOMMU page tables
>>
>> So, remove unused function completely.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Release-acked-by: Juergen Gross <jgross@suse.com>
Thank you all.
--
Regards,
Oleksandr Tyshchenko
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-09-30 11:05 ` Oleksandr
@ 2019-10-08 17:21 ` Oleksandr
2019-10-09 15:40 ` Julien Grall
0 siblings, 1 reply; 7+ messages in thread
From: Oleksandr @ 2019-10-08 17:21 UTC (permalink / raw)
To: Jürgen Groß, xen-devel
Cc: Oleksandr Tyshchenko, julien.grall, paul.durrant,
volodymyr_babchuk, sstabellini
Hi, all
Gentle reminder...
--
Regards,
Oleksandr Tyshchenko
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
2019-10-08 17:21 ` Oleksandr
@ 2019-10-09 15:40 ` Julien Grall
0 siblings, 0 replies; 7+ messages in thread
From: Julien Grall @ 2019-10-09 15:40 UTC (permalink / raw)
To: Oleksandr, Jürgen Groß, xen-devel
Cc: Oleksandr Tyshchenko, paul.durrant, volodymyr_babchuk, sstabellini
On 08/10/2019 18:21, Oleksandr wrote:
>
> Hi, all
Hi,
>
> Gentle reminder...
Sorry this fell through the cracks. I have now committed it.
Cheers,
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-09 15:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 10:34 [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely Oleksandr Tyshchenko
2019-09-30 10:35 ` Paul Durrant
2019-09-30 10:42 ` Julien Grall
2019-09-30 10:44 ` Jürgen Groß
2019-09-30 11:05 ` Oleksandr
2019-10-08 17:21 ` Oleksandr
2019-10-09 15:40 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).