From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v2 09/17] x86: use xvmalloc() for extended context buffer allocations
Date: Mon, 23 Nov 2020 15:31:19 +0100 [thread overview]
Message-ID: <1e352dd9-016c-d15e-c1bb-64fb28df8b73@suse.com> (raw)
In-Reply-To: <255f466c-3c95-88c5-3e55-0f04c9ae1b12@suse.com>
This is in preparation for the buffer sizes exceeding a page's worth of
space, as will happen with AMX as well as Architectural LBR.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -30,6 +30,7 @@
#include <xsm/xsm.h>
#include <xen/iommu.h>
#include <xen/vm_event.h>
+#include <xen/xvmalloc.h>
#include <public/vm_event.h>
#include <asm/mem_sharing.h>
#include <asm/xstate.h>
@@ -331,7 +332,7 @@ long arch_do_domctl(
goto sethvmcontext_out;
ret = -ENOMEM;
- if ( (c.data = xmalloc_bytes(c.size)) == NULL )
+ if ( (c.data = xvmalloc_bytes(c.size)) == NULL )
goto sethvmcontext_out;
ret = -EFAULT;
@@ -343,7 +344,7 @@ long arch_do_domctl(
domain_unpause(d);
sethvmcontext_out:
- xfree(c.data);
+ xvfree(c.data);
break;
}
@@ -373,7 +374,7 @@ long arch_do_domctl(
/* Allocate our own marshalling buffer */
ret = -ENOMEM;
- if ( (c.data = xmalloc_bytes(c.size)) == NULL )
+ if ( (c.data = xvmalloc_bytes(c.size)) == NULL )
goto gethvmcontext_out;
domain_pause(d);
@@ -386,7 +387,7 @@ long arch_do_domctl(
gethvmcontext_out:
copyback = true;
- xfree(c.data);
+ xvfree(c.data);
break;
}
@@ -904,7 +905,7 @@ long arch_do_domctl(
if ( !ret && size > PV_XSAVE_HDR_SIZE )
{
unsigned int xsave_size = size - PV_XSAVE_HDR_SIZE;
- void *xsave_area = xmalloc_bytes(xsave_size);
+ void *xsave_area = xvmalloc_bytes(xsave_size);
if ( !xsave_area )
{
@@ -918,7 +919,7 @@ long arch_do_domctl(
if ( copy_to_guest_offset(evc->buffer, offset, xsave_area,
xsave_size) )
ret = -EFAULT;
- xfree(xsave_area);
+ xvfree(xsave_area);
}
vcpu_unpause(v);
@@ -938,7 +939,7 @@ long arch_do_domctl(
evc->size > PV_XSAVE_SIZE(xfeature_mask) )
goto vcpuextstate_out;
- receive_buf = xmalloc_bytes(evc->size);
+ receive_buf = xvmalloc_bytes(evc->size);
if ( !receive_buf )
{
ret = -ENOMEM;
@@ -948,7 +949,7 @@ long arch_do_domctl(
offset, evc->size) )
{
ret = -EFAULT;
- xfree(receive_buf);
+ xvfree(receive_buf);
goto vcpuextstate_out;
}
@@ -966,7 +967,7 @@ long arch_do_domctl(
ret = 0;
if ( ret )
{
- xfree(receive_buf);
+ xvfree(receive_buf);
goto vcpuextstate_out;
}
@@ -994,7 +995,7 @@ long arch_do_domctl(
vcpu_unpause(v);
}
- xfree(receive_buf);
+ xvfree(receive_buf);
}
#undef PV_XSAVE_HDR_SIZE
--- a/xen/arch/x86/hvm/save.c
+++ b/xen/arch/x86/hvm/save.c
@@ -23,6 +23,7 @@
#include <xen/guest_access.h>
#include <xen/softirq.h>
#include <xen/version.h>
+#include <xen/xvmalloc.h>
#include <asm/hvm/support.h>
@@ -154,7 +155,7 @@ int hvm_save_one(struct domain *d, unsig
else
v = d->vcpu[instance];
ctxt.size = hvm_sr_handlers[typecode].size;
- ctxt.data = xmalloc_bytes(ctxt.size);
+ ctxt.data = xvmalloc_bytes(ctxt.size);
if ( !ctxt.data )
return -ENOMEM;
@@ -200,7 +201,7 @@ int hvm_save_one(struct domain *d, unsig
else
domain_unpause(d);
- xfree(ctxt.data);
+ xvfree(ctxt.data);
return rv;
}
next prev parent reply other threads:[~2020-11-23 14:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 14:21 [PATCH v2 00/17] xvmalloc() / x86 xstate area / x86 CPUID / AMX beginnings Jan Beulich
2020-11-23 14:23 ` [PATCH v2 01/17] mm: check for truncation in vmalloc_type() Jan Beulich
2020-11-25 12:00 ` Julien Grall
2020-11-23 14:23 ` [PATCH v2 02/17] mm: introduce xvmalloc() et al and use for grant table allocations Jan Beulich
2020-11-25 12:15 ` Julien Grall
2020-11-25 12:57 ` Jan Beulich
2020-11-25 19:48 ` Stefano Stabellini
2020-11-26 11:34 ` Jan Beulich
2020-11-26 13:22 ` Julien Grall
2020-11-26 15:18 ` Jan Beulich
2020-11-26 15:53 ` Julien Grall
2020-11-26 17:03 ` Jan Beulich
2020-11-23 14:27 ` [PATCH v2 03/17] x86/xstate: use xvzalloc() for save area allocation Jan Beulich
2020-11-23 14:28 ` [PATCH v2 04/17] x86/xstate: re-size save area when CPUID policy changes Jan Beulich
2020-11-23 14:28 ` [PATCH v2 05/17] x86/xstate: re-use valid_xcr0() for boot-time checks Jan Beulich
2020-11-23 14:29 ` [PATCH v2 06/17] x86/xstate: drop xstate_offsets[] and xstate_sizes[] Jan Beulich
2020-11-23 14:30 ` [PATCH v2 07/17] x86/xstate: replace xsave_cntxt_size and drop XCNTXT_MASK Jan Beulich
2020-11-23 14:30 ` [PATCH v2 08/17] x86/xstate: avoid accounting for unsupported components Jan Beulich
2020-11-23 14:31 ` Jan Beulich [this message]
2020-11-23 14:32 ` [PATCH v2 10/17] x86/xstate: enable AMX components Jan Beulich
2020-11-23 14:32 ` [PATCH v2 11/17] x86/CPUID: adjust extended leaves out of range clearing Jan Beulich
2021-02-11 15:40 ` Ping: " Jan Beulich
2021-04-15 12:33 ` Roger Pau Monné
2021-04-15 12:48 ` Andrew Cooper
2021-04-15 13:56 ` Jan Beulich
2020-11-23 14:33 ` [PATCH v2 12/17] x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents Jan Beulich
2021-02-11 15:42 ` Jan Beulich
2021-04-15 9:52 ` Roger Pau Monné
2021-04-15 10:37 ` Jan Beulich
2021-04-15 12:30 ` Roger Pau Monné
2021-04-15 14:10 ` Jan Beulich
2020-11-23 14:33 ` [PATCH v2 13/17] x86/CPUID: move bounding of max_{,sub}leaf fields to library code Jan Beulich
2020-11-23 14:34 ` [PATCH v2 14/17] x86/CPUID: enable AMX leaves Jan Beulich
2020-11-23 14:35 ` [PATCH v2 15/17] x86emul: introduce X86EMUL_FPU_tile Jan Beulich
2020-11-23 14:36 ` [PATCH v2 16/17] x86emul: support TILERELEASE Jan Beulich
2020-11-23 14:37 ` [PATCH v2 17/17] x86emul: support {LD,ST}TILECFG Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e352dd9-016c-d15e-c1bb-64fb28df8b73@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).