From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDDAC11F65 for ; Wed, 30 Jun 2021 17:44:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CC6761435 for ; Wed, 30 Jun 2021 17:44:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CC6761435 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.148214.273892 (Exim 4.92) (envelope-from ) id 1lyeG5-0000CI-De; Wed, 30 Jun 2021 17:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148214.273892; Wed, 30 Jun 2021 17:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyeG5-0000CB-Ai; Wed, 30 Jun 2021 17:44:21 +0000 Received: by outflank-mailman (input) for mailman id 148214; Wed, 30 Jun 2021 17:44:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyeG3-0000C5-OJ for xen-devel@lists.xenproject.org; Wed, 30 Jun 2021 17:44:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyeG2-0002Ss-Mo; Wed, 30 Jun 2021 17:44:18 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lyeG2-0004uz-Ex; Wed, 30 Jun 2021 17:44:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=kctGUokibAu8Zy2yd9F68eAYEDcyIIZZQYgRFk7raSU=; b=twU2abxlPox1MulXLnWvygR7+P 0Kl3P4JAqsDG3ZVBLh10g2oQqhfjzERJ35Y4Ajg6TBq/WfDJ/I11RW44A2cYhnOwuTcrseDkY92rX CsQebu0djS0s3xJjfgz5hKncQfV4jzTWWICyfSHH3XJraypZ448Iinb2xHK2HOmJZLuI=; Subject: Re: [PATCH 2/9] xen/arm: introduce PGC_reserved To: Penny Zheng , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com References: <20210607024318.3988467-1-penny.zheng@arm.com> <20210607024318.3988467-3-penny.zheng@arm.com> From: Julien Grall Message-ID: <1f1c1567-1a53-3b6a-2868-b7673d9180b3@xen.org> Date: Wed, 30 Jun 2021 18:44:16 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607024318.3988467-3-penny.zheng@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Penny, On 07/06/2021 03:43, Penny Zheng wrote: > In order to differentiate pages of static memory, from those allocated from > heap, this patch introduces a new page flag PGC_reserved to tell. I would prefer if this patch is folded in the patch first using it. This will be easier to understand how this flag will be used. Cheers, > > Signed-off-by: Penny Zheng > --- > changes v2: > - remove unused reserved field in struct page_info > - remove unused helper page_get_reserved_owner and page_set_reserved_owner > --- > xen/include/asm-arm/mm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h > index 0b7de3102e..7034fae1b6 100644 > --- a/xen/include/asm-arm/mm.h > +++ b/xen/include/asm-arm/mm.h > @@ -108,6 +108,9 @@ struct page_info > /* Page is Xen heap? */ > #define _PGC_xen_heap PG_shift(2) > #define PGC_xen_heap PG_mask(1, 2) > + /* Page is reserved */ > +#define _PGC_reserved PG_shift(3) > +#define PGC_reserved PG_mask(1, 3) > /* ... */ > /* Page is broken? */ > #define _PGC_broken PG_shift(7) > -- Julien Grall