From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Limpach Subject: Re: (no subject) Date: Mon, 19 Sep 2005 20:58:42 +0100 Message-ID: <20050919195842.GK9610@cl.cam.ac.uk> References: <516F50407E01324991DD6D07B0531AD5695D6A@cacexc12.americas.cpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <516F50407E01324991DD6D07B0531AD5695D6A@cacexc12.americas.cpqcorp.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Magenheimer, Dan (HP Labs Fort Collins)" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Sep 19, 2005 at 12:20:41PM -0700, Magenheimer, Dan (HP Labs Fort Collins) wrote: > > > OK, I see. This cleans it up nicely. New patch attached. > > > > You have to export LINUX_ARCH to the script. We don't want to > > unconditionally polute the environment of all the commands we > > run, so you'll have to add it to all the calls to mkbuildtree. > > I'm not sure I follow... I don't know exactly how make or bash > work wrt to exporting... I didn't explicitly export LINUX_ARCH > but it seems to be known by mkbuildtree and all the mk.linux's > anyway. (I successfully built for x86 and ia64 with the > patch.) > > Or are you suggesting I *not* define it in buildconfigs/Rules.mk > so as to avoid polluting the environment? Rules.mk is fine. What I meant is that LINUX_ARCH won't get passed to mkbuildtree unless you add it to its environment. I confirmed this now by adding this to mkbuildtree: echo ${LINUX_ARCH} >>/tmp/xxxxxxxx LINUX_ARCH is empty and thus your hook script won't run. Maybe you have LINUX_ARCH set in your shell environment where you ran make? Odd... > That's OK with me. If enlightenment (is that a bad word in > Xen land now?) from the above requires me to re-generate > the patch, I will change the names. Cheers! christian