From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Limpach Subject: Re: (no subject) Date: Mon, 19 Sep 2005 22:18:43 +0100 Message-ID: <20050919211843.GN9610@cl.cam.ac.uk> References: <516F50407E01324991DD6D07B0531AD5695D7C@cacexc12.americas.cpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <516F50407E01324991DD6D07B0531AD5695D7C@cacexc12.americas.cpqcorp.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Magenheimer, Dan (HP Labs Fort Collins)" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Sep 19, 2005 at 01:52:36PM -0700, Magenheimer, Dan (HP Labs Fort Collins) wrote: > > Rules.mk is fine. What I meant is that LINUX_ARCH won't get > > passed to mkbuildtree unless you add it to its environment. > > I confirmed this now by adding this to mkbuildtree: > > echo ${LINUX_ARCH} >>/tmp/xxxxxxxx > > LINUX_ARCH is empty and thus your hook script won't run. Maybe > > you have LINUX_ARCH set in your shell environment where you ran > > make? Odd... > > No, it's not in my shell environment. However, when I run make > to build for ia64 I run it as: 'make LINUX_ARCH=ia64 ...' and > I'm guessing make must export it to subshells. If I add the > 'echo', I do get ia64 in /tmp/xxxxxx and the ia64 hook scripts > do get run. Yes, that explains it. > I suppose it would be nice if on ia64 just 'make' did the > right thing, e.g. set LINUX_ARCH=ia64 without the need to > specify it on the command line. In that case, adding it > to all the calls to mkbuildtree is necessary. How do > I set LINUX_ARCH in Rules.mk so that it is set to 'xen' > if x86 (or x86_64) and the architecture it is running on > (e.g. ia64) otherwise? I'll check it in tomorrow, and I'll make it set LINUX_ARCH dependent on ARCH, like you did in your original patch... Thanks! christian