From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH RESEND] net: convert xen-netfront to hw_features
Date: Thu, 31 Mar 2011 13:37:27 +0200 [thread overview]
Message-ID: <20110331113727.GA19215@rere.qmqm.pl> (raw)
In-Reply-To: <1301570010.27123.172.camel@zakaz.uk.xensource.com>
On Thu, Mar 31, 2011 at 12:13:30PM +0100, Ian Campbell wrote:
> On Thu, 2011-03-31 at 12:01 +0100, Michał Mirosław wrote:
> > Not tested in any way. The original code for offload setting seems broken
> > as it resets the features on every netback reconnect.
> Thanks, I've got a pending TODO item to test this and propagate similar
> changes to netback. I hope to get to it soon...
>
> Is this urgent (for 2.6.39) IYHO? I think it's been broken this way for
> a long time now...
This probably affects only people who are using suspending VM's to disk or
[live] migration. The bug is hard to notice if you're not looking for it.
I only noticed it after trying to change the code.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-03-31 11:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 11:01 [PATCH RESEND] net: convert xen-netfront to hw_features Michał Mirosław
2011-03-31 11:13 ` Ian Campbell
2011-03-31 11:37 ` Michał Mirosław [this message]
2011-04-02 3:54 ` David Miller
2011-04-03 11:07 ` [PATCH] xen: netfront: fix declaration order Eric Dumazet
2011-04-03 17:35 ` Michał Mirosław
2011-04-04 0:24 ` David Miller
2011-04-04 9:55 ` [PATCH] xen: drop anti-dependency on X86_VISWS (Was: Re: [PATCH] xen: netfront: fix declaration order) Ian Campbell
2011-04-06 21:45 ` [PATCH] xen: drop anti-dependency on X86_VISWS David Miller
2011-04-07 6:58 ` Ian Campbell
2011-04-07 17:00 ` H. Peter Anvin
2011-04-08 6:46 ` Ian Campbell
2011-04-08 20:15 ` H. Peter Anvin
2011-04-07 18:07 ` Jeremy Fitzhardinge
2011-04-08 6:38 ` Ian Campbell
2011-04-08 15:25 ` Jeremy Fitzhardinge
2011-04-08 15:42 ` Jan Beulich
2011-04-08 18:24 ` Jeremy Fitzhardinge
2011-04-09 10:34 ` Ian Campbell
2011-04-14 8:20 ` Jeremy Fitzhardinge
2011-04-04 12:29 ` [PATCH RESEND] net: convert xen-netfront to hw_features Ian Campbell
2011-04-04 18:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331113727.GA19215@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).