From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] xen{trace/analyze}: don't use 64bit versions of libc functions
Date: Fri, 19 Jun 2015 14:07:46 +0100 [thread overview]
Message-ID: <20150619130746.GH28194@zion.uk.xensource.com> (raw)
In-Reply-To: <1434704305-64692-2-git-send-email-roger.pau@citrix.com>
On Fri, Jun 19, 2015 at 10:58:24AM +0200, Roger Pau Monne wrote:
> This is not needed, neither encouraged. Configure already checks
> _FILE_OFFSET_BITS and appends it when needed, so that the right functions
> are used. Also remove the usage of loff_t and O_LARGEFILE for the same
> reason.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Olaf Hering <olaf@aepfle.de>
Acked-by: Wei Liu <wei.liu2@citrix.com>
next prev parent reply other threads:[~2015-06-19 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 8:58 [PATCH 0/2] xen{trace/analyze}: fix build on FreeBSD Roger Pau Monne
2015-06-19 8:58 ` [PATCH 1/2] xen{trace/analyze}: don't use 64bit versions of libc functions Roger Pau Monne
2015-06-19 13:07 ` Wei Liu [this message]
2015-06-22 9:08 ` George Dunlap
2015-06-22 9:59 ` Roger Pau Monné
2015-06-22 10:09 ` George Dunlap
2015-06-22 14:48 ` Roger Pau Monné
2015-06-24 11:11 ` Roger Pau Monné
2015-06-24 13:02 ` Roger Pau Monné
2015-06-24 13:08 ` George Dunlap
2015-06-19 8:58 ` [PATCH 2/2] configure: check for argp Roger Pau Monne
2015-06-19 13:10 ` Wei Liu
2015-06-22 10:12 ` George Dunlap
2015-06-22 10:45 ` Wei Liu
2015-06-22 10:55 ` George Dunlap
2015-06-22 11:10 ` Wei Liu
2015-06-22 11:13 ` George Dunlap
2015-06-25 12:01 ` [PATCH 0/2] xen{trace/analyze}: fix build on FreeBSD Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619130746.GH28194@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).