From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: Requesting for freeze exception for RMRR
Date: Tue, 14 Jul 2015 10:29:15 +0100
Message-ID: <20150714092915.GC4152@zion.uk.xensource.com>
References: <55A35B5E.3000805@intel.com>
	<20150713114145.GF4108@zion.uk.xensource.com>
	<55A46575.5020607@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <55A46575.5020607@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Kevin <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>, "Wang,
	Yong Y" <yong.y.wang@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jul 14, 2015 at 09:27:17AM +0800, Chen, Tiejun wrote:
> >Please work with maintainers to get those hvmloader patches acked or
> >reviewed.
> 
> I will do.
> 
> >
> >>
> >>Note Jackson and Campbell also raised some comments to improve current
> >>codes.
> >>
> >>2. explain why it needs to be in this release (benefits).
> >>
> >>RMRR mechanism was broken for a long time and this makes VM always face
> >>security issues. In addition, those associated devices can't be passed
> >>through to VM and even result in VM crashes.
> >>
> >>3. explain why it doesn't break things (risks).
> >>
> >>Our policy makes sure that system will work in the original way by default
> >>as without the RMRR patches. And especially, this series just impacts those
> >>platforms which have RMRR.
> >>
> >
> >Your patches touch crucial path in hvmloader to build memory map. There
> >is risk that it may break hvmloader even if it is turned off.
> >
> >I would need at least some positive test results from you to confirm if
> >this feature is turned off everything works as before.
> >
> 
> Could you show what sort of test you need here? I just did boot a VM without
> any RDM parameters. I just think maybe someone had this good experience to
> check this.
> 

Yes, this is the basic test I need -- at least booting a VM with RDM
off.

Feel free to do more tests and report back if you have time.

Wei.

> Thanks
> Tiejun