From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH for-4.6] tools/hotplug: Add an initscript to start "xl devd" in a driver domain Date: Wed, 15 Jul 2015 14:26:49 +0100 Message-ID: <20150715132649.GA12455@zion.uk.xensource.com> References: <1436890874.11153.14.camel@citrix.com> <1436958450-14336-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1436958450-14336-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, George Dunlap , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org On Wed, Jul 15, 2015 at 12:07:30PM +0100, Ian Campbell wrote: > The removal of the udev rules highlighted that although it has been > replaced by "xl devd" there isn't an initscript to replace it. > = > To enable this add a --pidfile option to xl devd. > = > Tested on Linux by running the script in dom0 and checking the daemon > was started/stopped, but not in an actual driver domain environment > since I don't have one conveniently available. I also checked that > running without the --pidfile option still works. > = > Scripts mainly cribbed from the xencommons for each platform. > = > Signed-off-by: Ian Campbell > Cc: Roger Pau Monn=E9 > Cc: Konrad Rzeszutek Wilk > Cc: George Dunlap > --- > For 4.6: I think having removed the udev rules we ought to include > this, it's basically zero risk to normal operation. > = > Nothing seems to start xl devd for domain 0 in *BSD, nor is xenbackend > started. Is that correct? > --- > .gitignore | 3 ++ > tools/configure | 5 +- > tools/configure.ac | 3 ++ > tools/hotplug/FreeBSD/Makefile | 2 +- > tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 48 +++++++++++++++++ > tools/hotplug/Linux/Makefile | 3 ++ > tools/hotplug/Linux/init.d/xendriverdomain.in | 77 +++++++++++++++++++++= ++++++ > tools/hotplug/NetBSD/Makefile | 2 +- > tools/hotplug/NetBSD/rc.d/xendriverdomain.in | 49 +++++++++++++++++ > tools/libxl/xl_cmdimpl.c | 42 +++++++++++++-- > tools/libxl/xl_cmdtable.c | 3 +- Systemd unit file is missing. Wei.