From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 2/5] xl: Command line: Remove maximum
 argument limit for network-attach
Date: Mon, 20 Jul 2015 11:00:19 +0100
Message-ID: <20150720100019.GD12455@zion.uk.xensource.com>
References: <1437152451-22507-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437152451-22507-2-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1437152451-22507-2-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 17, 2015 at 06:00:48PM +0100, Ian Jackson wrote:
> This limit of 11 has been in this function since it was written, but
> serves no purpose.  The extra arguments are fed one by one to
> parse_nic_config, and it is possible to have as many as you like.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/libxl/xl_cmdimpl.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 55c041c..770b71c 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6373,11 +6373,6 @@ int main_networkattach(int argc, char **argv)
>          /* No options */
>      }
>  
> -    if (argc-optind > 11) {
> -        help("network-attach");
> -        return 0;
> -    }
> -
>      domid = find_domain(argv[optind]);
>  
>      config= xlu_cfg_init(stderr, "command line");
> -- 
> 1.7.10.4