From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 3/5] xl: Command line: Support -h everywhere
Date: Mon, 20 Jul 2015 11:06:21 +0100
Message-ID: <20150720100621.GE12455@zion.uk.xensource.com>
References: <1437152451-22507-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437152451-22507-3-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1437152451-22507-3-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 17, 2015 at 06:00:49PM +0100, Ian Jackson wrote:
> xl subcommands ought all to take -h.  def_getopt and hence
> SWITCH_FOREACH_OPT already handles 'h' by calling helpstr.  None of
> the call sites see the 'h'.
> 
> In this patch:
> 
>  * Change SWITCH_FOREACH_OPT to always add a "h" to the short opts
>    string, using string concatenation.
> 
>  * Remove the now-redundant h's from some existing option strings.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>