Re: [PATCH OSSTEST 3/4] ts-devstack: Deploy OpenStack then test it with Tempest

[Anthony PERARD <anthony.perard@citrix.com>]

On Fri, Jul 17, 2015 at 05:04:03PM +0100, Ian Campbell wrote:
> On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote:
> > +    cd $builddir/devstack
> > +    >local.conf
> > +    echo >>local.conf '[[local|localrc]]'
> > +    echo >>local.conf ADMIN_PASSWORD=`pwgen 20 1`
> > +    echo >>local.conf DATABASE_PASSWORD=`pwgen 20 1`
> > +    echo >>local.conf RABBIT_PASSWORD=`pwgen 20 1`
> > +    echo >>local.conf SERVICE_PASSWORD=`pwgen 20 1`
> > +    echo >>local.conf SERVICE_TOKEN=`pwgen 20 1`
> > +    echo >>local.conf \\\# make it small because there is no way to not
> > +    echo >>local.conf \\\# have this lvm volume created
> > +    echo >>local.conf VOLUME_BACKING_FILE_SIZE=500M
> > +    echo >>local.conf DEST=/opt/stack
> > +    echo >>local.conf LOGFILE=\\\$DEST/logs/stack.sh.log
> > +    echo >>local.conf LOG_COLOR=False
> > +    echo >>local.conf LIBVIRT_TYPE=xen
> > +    echo >>local.conf GIT_BASE="$openstack_git_base"
> > +    echo >>local.conf disable_service horizon
> > +    echo >>local.conf disable_service n-novnc
> > +    echo >>local.conf enable_service n-obj
> > +    echo >>local.conf '[[post-config|\$CINDER_CONF]]'
> > +    echo >>local.conf '[lvmdriver-1]'
> > +    echo >>local.conf volume_group = $vg
> 
> target_putfilecontents_root_stash with a Perl here doc would be  better
> I think?

Will use the function. I guest I just need to replace pwgen by something in
perl. I think services are accessible from the network, which is why I'm
using pwgen.

> > +[...]+
> > +  # OpenStack needs access to libvirt from a user.
> > +  target_cmd_root($ho, <<END
> > +    echo >>/etc/libvirt/libvirtd.conf 'unix_sock_group = "libvirt"'
> > +    echo >>/etc/libvirt/libvirtd.conf 'unix_sock_ro_perms = "0777"'
> > +    echo >>/etc/libvirt/libvirtd.conf 'unix_sock_rw_perms = "0770"'
> 
> This one should be a bash heredoc, I think (can't be a Perl one because
> this is an append?).

This is append to the existing libvirtd.conf, yes. I'll use bash heredoc.
Or is target_editfile_root() can be used to add lines at the end?

> > +sub cleanup() {
> > +  # Try to have less leaked stuff.
> 
> Leaked as in "discovered by ts-leak-check" or just a general tidy up?
> 
> If the latter I wouldn't bother.
> 
> If the former then won't this hide real issues?

I've added this when I've seen many "leaked" process from OpenStack by
ts-leak-check. I can try to teach the ts- script to not considered as
leaked, process and other files from openstack.

-- 
Anthony PERARD