From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest Date: Tue, 21 Jul 2015 13:49:45 +0100 Message-ID: <20150721124945.GR12455@zion.uk.xensource.com> References: <1437151878-11792-1-git-send-email-andrew.cooper3@citrix.com> <20150720095639.GC12455@zion.uk.xensource.com> <55ACC950.2080806@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <55ACC950.2080806@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > On 20/07/15 10:56, Wei Liu wrote: > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > >> And three improvements to debugging. > >> > >> Note that there is still a bug in libxl__toolstack_save() which > >> valgrind identified, but I do not wish to block this bugfix on that > >> > >> Andrew Cooper (4): > >> tools/libxc: Identify the path of the kernel image which cannot be > >> found > >> tools/libxl: Log the subject fd in datacopier messages > >> tools/libxl: Identify copywhat in stream v2 datacopiers > > I think all three patches should wait until next development window > > opens unless we have nothing else in our queue (which doesn't seem to be > > the case at the moment). > > You mean delay until 4.7? I disagree. Without these fixes, debugging > issues is substantially harder than they need to be. > > They literally are only adding extra information into existing error > messages. > Well I am expecting two to three big series getting applied soon, any changes that gets applied now has the chance of forcing those series to be rebased. Let's at least wait until next week. Wei. > ~Andrew