From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support
Date: Tue, 21 Jul 2015 17:17:38 +0100 [thread overview]
Message-ID: <20150721161738.GS12455@zion.uk.xensource.com> (raw)
In-Reply-To: <1436786632.7019.105.camel@citrix.com>
On Mon, Jul 13, 2015 at 12:23:52PM +0100, Ian Campbell wrote:
> On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
>
> Perhaps the libvirt part of the check_for_command stuff ought to be
> moved here? Otherwise we are claiming support before the code is
> actually willing to try to do so.
I move this patch before "toolstack: distinguish local and remote
migration support" (the patch that claims support). It should be fine
now.
Wei.
>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> > Osstest/Toolstack/libvirt.pm | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
> > index ddf84df..3dc1856 100644
> > --- a/Osstest/Toolstack/libvirt.pm
> > +++ b/Osstest/Toolstack/libvirt.pm
> > @@ -105,17 +105,22 @@ sub saverestore_check ($) {
> >
> > sub migrate ($) {
> > my ($self,$gho,$dst,$timeout) = @_;
> > - die "Migration is not yet supported on libvirt.";
> > + my $ho = $self->{Host};
> > + my $gn = $gho->{Name};
> > + target_cmd_root($ho, "virsh migrate $gn $dst", $timeout);
> > }
> >
> > sub save ($$$$) {
> > my ($self,$gho,$f,$timeout) = @_;
> > - die "Save is not yet supported on libvirt.";
> > + my $ho = $self->{Host};
> > + my $gn = $gho->{Name};
> > + target_cmd_root($ho, "virsh save $gn $f", $timeout);
> > }
> >
> > sub restore ($$$$) {
> > my ($self,$gho,$f,$timeout) = @_;
> > - die "Restore is not yet supported on libvirt.";
> > + my $ho = $self->{Host};
> > + target_cmd_root($ho, "virsh restore $f", $timeout);
> > }
> >
> > 1;
>
next prev parent reply other threads:[~2015-07-21 16:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 16:20 [PATCH OSSTEST v2 00/13] Libvirt migration and HVM tests Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 01/13] toolstack: save / restore check Wei Liu
2015-07-13 11:09 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 02/13] Introduce ts-saverestore-support-check Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables Wei Liu
2015-07-13 11:14 ` Ian Campbell
2015-07-21 16:32 ` Ian Jackson
2015-07-21 17:12 ` Wei Liu
2015-07-21 17:36 ` Ian Jackson
2015-07-22 9:44 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 04/13] toolstack: distinguish local and remote migration support Wei Liu
2015-07-13 11:19 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 05/13] sg-run-job: remove save/restore dependency on local " Wei Liu
2015-07-13 11:22 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support Wei Liu
2015-07-13 11:23 ` Ian Campbell
2015-07-21 16:17 ` Wei Liu [this message]
2015-07-12 16:20 ` [PATCH OSSTEST v2 07/13] ts-xen-build-prep: install ebtables Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite Wei Liu
2015-07-13 11:25 ` Ian Campbell
2015-07-21 16:22 ` Wei Liu
2015-07-21 16:33 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios Wei Liu
2015-07-13 11:27 ` Ian Campbell
2015-07-21 16:24 ` Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 10/13] TestSupport: don't put kernel='hvmloader' in HVM config Wei Liu
2015-07-13 11:28 ` Ian Campbell
2015-07-13 11:34 ` Ian Campbell
2015-07-12 16:20 ` [PATCH OSSTEST v2 11/13] make-flight: debian hvm tests with libvirt Wei Liu
2015-07-13 11:33 ` Ian Campbell
2015-07-13 13:12 ` Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 12/13] make-flight, mfi-common: rename onetoolstack to pairtoolstack Wei Liu
2015-07-12 16:20 ` [PATCH OSSTEST v2 13/13] make-flight, mfi-common: create live migration test for libvirt Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721161738.GS12455@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).