From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status Date: Wed, 22 Jul 2015 12:22:42 +0100 Message-ID: <20150722112242.GA6831@zion.uk.xensource.com> References: <1437388679-16468-1-git-send-email-andrew.cooper3@citrix.com> <1437561186.12884.14.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1437561186.12884.14.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , Wen Congyang , Andrew Cooper , Ian Jackson , Xen-devel , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Wed, Jul 22, 2015 at 11:33:06AM +0100, Ian Campbell wrote: > On Mon, 2015-07-20 at 11:37 +0100, Andrew Cooper wrote: > > This series is some cleanup following the integration of migration v2 > > into the codebase. It removes the legacy migration implementation > > (compatability is provided with the python conversion script), and > > adjusts the migration v2 docs/implementation to no longer be > > experimental. > > IMHO we should take this for 4.6, there is no point in shipping > obsolete/unused code and leaving it there with the xc_domain_save name > and the supported thing with a 2 suffix will only tempt people to > continue to use or build on it. > > The only real risk here is breaking the build, since if it builds it > will surely work. > > Wei, final call is yours. > Yes. I agree with you. But please do check this doesn't conflict with COLOPre before applying. Wei. > Ian. > > > > > There are no major changes in this series, but are important changes > > for the status of migration v2 in Xen 4.6 > > > > Andrew Cooper (6): > > tools/libxc: Remove legacy migration implementation > > tools/libx{l,c}: Remove the toolstack_{save,restore} callbacks > > tools/libx{l,c}: Remove XC_DEVICE_MODEL_RESTORE_FILE > > tools/libx{l,c}: Drop '2' suffixes from xc_domain_{save,restore}2() > > functions > > docs: Migration v2 is now no longer draft > > tools/libx{l,c}: Fix trivial Coverity defects in migration v2 code > > > > docs/specs/libxc-migration-stream.pandoc | 19 +- > > docs/specs/libxl-migration-stream.pandoc | 19 +- > > tools/libxc/Makefile | 1 - > > tools/libxc/include/xenguest.h | 34 - > > tools/libxc/xc_domain_restore.c | 2411 -------------------- > > ---------- > > tools/libxc/xc_domain_save.c | 2198 -------------------- > > ------- > > tools/libxc/xc_nomigrate.c | 20 - > > tools/libxc/xc_offline_page.c | 59 + > > tools/libxc/xc_sr_restore.c | 15 +- > > tools/libxc/xc_sr_save.c | 17 +- > > tools/libxc/xg_save_restore.h | 247 --- > > tools/libxl/libxl.c | 2 +- > > tools/libxl/libxl_create.c | 2 +- > > tools/libxl/libxl_internal.h | 2 +- > > tools/libxl/libxl_save_callout.c | 2 - > > tools/libxl/libxl_save_helper.c | 4 +- > > tools/libxl/libxl_stream_read.c | 4 +- > > 17 files changed, 107 insertions(+), 4949 deletions(-) > > delete mode 100644 tools/libxc/xc_domain_restore.c > > delete mode 100644 tools/libxc/xc_domain_save.c > >