From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC] libxl: fix build with glibc < 2.9
Date: Wed, 22 Jul 2015 13:24:48 +0100 [thread overview]
Message-ID: <20150722122448.GD6831@zion.uk.xensource.com> (raw)
In-Reply-To: <1437487589.8383.34.camel@citrix.com>
On Tue, Jul 21, 2015 at 03:06:29PM +0100, Ian Campbell wrote:
> On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote:
> > htobe*() and be*toh() don't exist there. While replacing the 32-bit
> > ones with hton() and ntoh() would be possible, there wouldn't be an
> > obvious replacement for the 64-bit ones. Hence just take what current
> > glibc (2.21) has (assuming __bswap_*() exists, which it does back to
> > at least 2.4 according to my checking).
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > ---
> > Not sure whether I picked an appropriate header to place this in, or
> > an appropriate #ifdef to hook this onto. Hence the RFC.
>
> I think they will do.
>
> I was a bit confused by xl.c including libxl_osdeps.h, but I think that
> is an aberration and we don't install the header so it is not really
> "public".
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
I was about to object putting them in libxl_osdep.h because they are not
really OS-dependent. However we've dumped something similar there before
so I withdraw my objection.
FWIW
Acked-by: Wei Liu <wei.liu2@citrix.com>
prev parent reply other threads:[~2015-07-22 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:30 [PATCH RFC] libxl: fix build with glibc < 2.9 Jan Beulich
2015-07-21 14:06 ` Ian Campbell
2015-07-22 12:24 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722122448.GD6831@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).