Re: [PATCH v4 2/3] libxl: localtime(3) can return NULL

From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4 2/3] libxl: localtime(3) can return NULL
Date: Wed, 22 Jul 2015 16:09:03 +0100	[thread overview]
Message-ID: <20150722150903.GC16933@zion.uk.xensource.com> (raw)
In-Reply-To: <1437574748.19412.6.camel@citrix.com>

On Wed, Jul 22, 2015 at 03:19:08PM +0100, Ian Campbell wrote:
> On Fri, 2015-07-17 at 18:12 +0100, Wei Liu wrote:
> > On Fri, Jul 17, 2015 at 06:05:45PM +0100, Ian Jackson wrote:
> > > Wei Liu writes ("[PATCH v4 2/3] libxl: localtime(3) can return 
> > > NULL"):
> > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > 
> > > >          tm = localtime(&t);
> > > > +        if (!tm) {
> > > > +            LOG(ERROR, "Failed to call localtime");
> > > 
> > > localtime sets errno if it fails.  So you mean LOGE.
> > > 
> > 
> > Heh. Linux manpage doesn't say so. But
> > 
> > http://pubs.opengroup.org/onlinepubs/009695399/functions/localtime.ht
> > ml
> > 
> > does say that.
> > 
> > I will rework this patch and send it out next week with other 
> > coverity
> > scan inspired patches I accumulate.
> 
> Should we not be using localtime_t in libxl? Afterall we don't know
> what other threads in the application might be doing.
> 

I guess you mean localtime_r.

I agree with you we should use that one.

Wei.