From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, Tiejun Chen <tiejun.chen@intel.com>,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: libxl: Use correct printf format for uint64_t
Date: Fri, 24 Jul 2015 11:42:42 +0100 [thread overview]
Message-ID: <20150724104242.GD30594@zion.uk.xensource.com> (raw)
In-Reply-To: <1437734477-31933-1-git-send-email-ian.campbell@citrix.com>
On Fri, Jul 24, 2015 at 11:41:17AM +0100, Ian Campbell wrote:
> Since 25652f232cbe "tools/libxl: detect and avoid conflicts with RDM"
> the build is broken for x86_32 and arm32 with:
>
> libxl_dm.c: In function ‘libxl__domain_device_construct_rdm’:
> libxl_dm.c:349:13: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 8 has type ‘uint64_t’ [-Werror=format=]
> LOG(ERROR, "RDM conflict at 0x%lx.\n", d_config->rdms[i].start);
> ^
> libxl_dm.c:352:13: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 8 has type ‘uint64_t’ [-Werror=format=]
> LOG(WARN, "Ignoring RDM conflict at 0x%lx.\n",
>
> Use PRIx64 for these.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Tiejun Chen <tiejun.chen@intel.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libxl/libxl_dm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 8d103c3..8ac007a 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -346,10 +346,11 @@ int libxl__domain_device_construct_rdm(libxl__gc *gc,
> continue;
>
> if (d_config->rdms[i].policy == LIBXL_RDM_RESERVE_POLICY_STRICT) {
> - LOG(ERROR, "RDM conflict at 0x%lx.\n", d_config->rdms[i].start);
> + LOG(ERROR, "RDM conflict at 0x%"PRIx64".\n",
> + d_config->rdms[i].start);
> goto out;
> } else {
> - LOG(WARN, "Ignoring RDM conflict at 0x%lx.\n",
> + LOG(WARN, "Ignoring RDM conflict at 0x%"PRIx64".\n",
> d_config->rdms[i].start);
>
> /*
> --
> 2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-07-24 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 10:41 [PATCH] tools: libxl: Use correct printf format for uint64_t Ian Campbell
2015-07-24 10:42 ` Ian Jackson
2015-07-24 10:42 ` Wei Liu [this message]
2015-07-24 11:08 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724104242.GD30594@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).