From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Lucina Subject: Re: [PATCH] xenconsole: Ensure exclusive access to console using locks Date: Fri, 24 Jul 2015 15:40:27 +0200 Message-ID: <20150724134027.GE25338@nodbug.lucina.net> References: <1437738262.24746.79.camel@citrix.com> <1437742310-14193-1-git-send-email-martin@lucina.net> <1437743460.24746.88.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIdD7-0000xX-L0 for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 13:40:25 +0000 Content-Disposition: inline In-Reply-To: <1437743460.24746.88.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Friday, 24.07.2015 at=A014:11, Ian Campbell wrote: > I'm afraid this (delving into another components private headers) isn't > allowed. Instead you should add the two lines to tools/console/Makefile > to generate a local _paths.h: > = > genpath-target =3D $(call buildmakevars2header,_paths.h) > $(eval $(genpath-target)) > = > Plus a dependency on it in the xenconsole rule and a .gitignore entry. > = > You might want to generate client/_paths.h instead to avoid needing to > muck around with CFLAGS. The above works, but causes genpath-target to be re-run each time "make" is called in tools/console, i.e. no longer says "Nothing to be done for all". I presume that's ok? > I think you can use string concatenation here, e.g. > XEN_LOCK_DIR "/xenconsole.%d" > = > = > Given the known limits on the size of domid it would probably be > possible to figure out a tighter limit than PATH_MAX. Ok, I can just make it the usual 255 ... Martin