From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "security@kernel.org" <security@kernel.org>,
Jan Beulich <jbeulich@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
xen-devel <xen-devel@lists.xen.org>,
stable <stable@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Sasha Levin <sasha.levin@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v3 1/3] x86/ldt: Make modify_ldt synchronous
Date: Sat, 25 Jul 2015 10:37:27 +0200 [thread overview]
Message-ID: <20150725083727.GB3427__38005.7021430277$1437813550$gmane$org@nazgul.tnic> (raw)
In-Reply-To: <CALCETrX=uGdTfmz7KkbVyMKEmwcS4C43L5eNsy65VjNsL=7KJA@mail.gmail.com>
On Fri, Jul 24, 2015 at 09:52:01PM -0700, Andy Lutomirski wrote:
> I see your wide terminal and raise you a complete rewrite of that
> function. Sigh, why did I assume the old code was the right way to do
> it?
That's a mostly wrong assumption, as experience proves.
> Hah¸ we both missed it. This is wrong. (Fix your backport!)
Yikes:
alloc_size = size * LDT_ENTRY_SIZE;
But hey, I made you spot it, still! :-)
Done.
> I'm not sure this is correct, so I changed it to something obviously
> correct (kmalloc/kfree).
Someone thought she won't get contiguous memory from kmalloc(). But how
big can alloc_size be to fail...
> You read too many of Linus' comments about using wider terminals :)
Nah, I'm just trying to put back some sanity in that 80 cols rule which,
even you, think is a hard one. And I say, keep 80 cols but sanity can
override it if what 80 cols produces, is crap.
I trust you're sane enough to apply that and not think C++ or java
wankery. Woahahahah...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-07-25 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1437592883.git.luto@kernel.org>
2015-07-22 19:23 ` [PATCH v3 1/3] x86/ldt: Make modify_ldt synchronous Andy Lutomirski
2015-07-22 19:23 ` [PATCH v3 2/3] x86/ldt: Make modify_ldt optional Andy Lutomirski
2015-07-22 19:23 ` [PATCH v3 3/3] selftests/x86, x86/ldt: Add a selftest for modify_ldt Andy Lutomirski
[not found] ` <7bfde005b84a90a83bf668a320c7d4ad1b940065.1437592883.git.luto@kernel.org>
2015-07-23 7:13 ` [PATCH v3 2/3] x86/ldt: Make modify_ldt optional Jan Beulich
2015-07-23 10:24 ` Willy Tarreau
[not found] ` <20150723102434.GA2929@1wt.eu>
2015-07-23 23:36 ` Kees Cook
[not found] ` <CAGXu5j+yEWLuxJ9JUGyN7BxME+iOVXfpFgrZ-_2WXUn6A=0dVg@mail.gmail.com>
2015-07-23 23:40 ` Andy Lutomirski
[not found] ` <CALCETrVvfA+_N_tU2LUwvh+2Q_4AExbQkSgW1C4tESAvhY+4Dg@mail.gmail.com>
2015-07-23 23:58 ` Willy Tarreau
[not found] ` <20150723235805.GA3191@1wt.eu>
2015-07-24 0:09 ` Kees Cook
[not found] ` <CAGXu5jJNfMvvdr0q17nBz+HiEJuFa7Kvo=ZPAnb4E7So4W0QOA@mail.gmail.com>
2015-07-24 7:24 ` Willy Tarreau
[not found] ` <20150724072451.GB3293@1wt.eu>
2015-07-24 7:48 ` Willy Tarreau
[not found] ` <049fdbab8ae2ecac1c8b40ecd558e9df45ccd5d3.1437592883.git.luto@kernel.org>
2015-07-22 22:20 ` [PATCH v3 1/3] x86/ldt: Make modify_ldt synchronous Boris Ostrovsky
2015-07-24 6:37 ` Borislav Petkov
2015-07-24 15:29 ` Borislav Petkov
[not found] ` <55B01745.4010702@oracle.com>
2015-07-25 4:13 ` Boris Ostrovsky
[not found] ` <55B30CE3.2010902@oracle.com>
2015-07-25 4:58 ` Andy Lutomirski
[not found] ` <20150724152955.GC21441@nazgul.tnic>
2015-07-25 4:52 ` Andy Lutomirski
[not found] ` <CALCETrX=uGdTfmz7KkbVyMKEmwcS4C43L5eNsy65VjNsL=7KJA@mail.gmail.com>
2015-07-25 8:37 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20150725083727.GB3427__38005.7021430277$1437813550$gmane$org@nazgul.tnic' \
--to=bp@alien8.de \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sasha.levin@oracle.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).