From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction Date: Mon, 10 Aug 2015 12:07:37 -0400 Message-ID: <20150810160737.GB12807__44347.3660191104$1439223036$gmane$org@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-2-git-send-email-daniel.kiper@oracle.com> <20150724162257.GB2220@l.oracle.com> <20150727194608.GB3492@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZOpcn-0001R6-3t for xen-devel@lists.xenproject.org; Mon, 10 Aug 2015 16:08:33 +0000 Content-Disposition: inline In-Reply-To: <20150727194608.GB3492@olila.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: jgross@suse.com, grub-devel@gnu.org, wei.liu2@citrix.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org On Mon, Jul 27, 2015 at 09:46:08PM +0200, Daniel Kiper wrote: > On Fri, Jul 24, 2015 at 12:22:57PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: > > > Signed-off-by: Daniel Kiper > > > > Don't you use it in: > > > > /* Switch to low-memory stack. */ > > 193 mov sym_phys(trampoline_phys),%edi > > 194 lea 0x10000(%edi),%esp > > 195 lea trampoline_boot_cpu_entry-trampoline_start(%edi),%eax > > ? > > Yep, but... > > > > --- > > > xen/arch/x86/boot/head.S | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > > > index cfd59dc..f63b349 100644 > > > --- a/xen/arch/x86/boot/head.S > > > +++ b/xen/arch/x86/boot/head.S > > > @@ -169,7 +169,6 @@ __start: > > > /* Apply relocations to bootstrap trampoline. */ > > > mov sym_phys(trampoline_phys),%edx > > ...relevant value is stored in sym_phys(trampoline_phys) earlier then it is > read into %edx here and... > > > > mov $sym_phys(__trampoline_rel_start),%edi > > > - mov %edx,sym_phys(trampoline_phys) > > ...it is put back to sym_phys(trampoline_phys) without any change here :-))). > So, I suppose this is remnant from something which was removed once but > somebody forgot to remove this instruction too... This patch fixes it. Reviewed-by: Konrad Rzeszutek Wilk