From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: manual merge of the xen-tip tree with the tip tree
Date: Wed, 12 Aug 2015 19:21:05 +0200
Message-ID: <20150812172105.GW16853@twins.programming.kicks-ass.net>
References: <20150812150954.36bc605c@canb.auug.org.au>
 <55CB49CA.8050305@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-next-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <55CB49CA.8050305@oracle.com>
Sender: linux-next-owner@vger.kernel.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Jeremy Fitzhardinge <jeremy@goop.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Xen Devel <Xen-devel@lists.xensource.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote:

> Incidentally, 11276d53 ("locking/static_keys: Add a new static_key
> interface") breaks old-ish compilers (gcc version 4.4.4 20100503 (Red=
 Hat
> 4.4.4-2) (GCC)):
>=20
>=20
>=20
>   CC      arch/x86/kernel/nmi.o
> In file included from
> /home/build/linux-boris/include/linux/jump_label.h:109,
>                  from
> /home/build/linux-boris/arch/x86/include/asm/spinlock.h:5,
>                  from /home/build/linux-boris/include/linux/spinlock.=
h:88,
>                  from /home/build/linux-boris/arch/x86/kernel/nmi.c:1=
4:
> /home/build/linux-boris/arch/x86/include/asm/jump_label.h: In functio=
n
> =E2=80=98nmi_handle=E2=80=99:
> /home/build/linux-boris/arch/x86/include/asm/jump_label.h:21: warning=
: asm
> operand 0 probably doesn=E2=80=99t match constraints
> /home/build/linux-boris/arch/x86/include/asm/jump_label.h:21: error:
> impossible constraint in =E2=80=98asm=E2=80=99
> make[3]: *** [arch/x86/kernel/nmi.o] Error 1
> make[2]: *** [arch/x86/kernel] Error 2
> make[1]: *** [arch/x86] Error 2

Ugh bugger.

I bet its that: &((char *)key)[branch] business, an earlier variant
thereof tripped up more recent GCCs too.

So its an __always_inline function, and both argument are always compil=
e
time constants, @key is the address of an object in static storage (a
global) and @branch is a simple 0/1 at the call site.

Now we wish to compute (unsigned long)key + branch at compile/link time
to feed to the assembler as an immediate, which should be possible,
given its all 'constants'.

It just appears GCC is having a hard time with this.

Let me see if I have a sufficiently old GCC around to play with.