From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v2 1/2] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Date: Mon, 21 Sep 2015 20:36:34 +0200 Message-ID: <20150921183634.GE3666__20407.2606553838$1442860691$gmane$org@pd.tnic> References: <130a3b7ef4788baae3a6fe71293ab17442bc9a0a.1442793572.git.luto@kernel.org> <20150921084642.GA30984@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andy Lutomirski Cc: Andrew Morton , KVM list , Peter Zijlstra , Linus Torvalds , the arch/x86 maintainers , Linux Kernel Mailing List , xen-devel , Paolo Bonzini , Thomas Gleixner , Arjan van de Ven , Ingo Molnar List-Id: xen-devel@lists.xenproject.org On Mon, Sep 21, 2015 at 11:16:30AM -0700, Andy Lutomirski wrote: > In the interest of sanity, I want to drop the "native_", too, since > there appear to be few or no good use cases for native_read_msr as > such. I'm tempted to add new functions read_msr and write_msr that > forward to rdmsrl_safe and wrmsrl_safe. Just change the msr_read/msr_write() ones in arch/x86/lib/msr.c to take a u64 and you're there. > It looks like the msr helpers are every bit as bad as the TSC helpers > used to be :( Yap. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.