From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl() Date: Fri, 19 Feb 2016 22:06:09 +0100 Message-ID: <20160219210609.GU25240@wotan.suse.de> References: <1455889559-9428-1-git-send-email-mcgrof@kernel.org> <1455889559-9428-5-git-send-email-mcgrof@kernel.org> <56C77A8B.7080800@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56C77A8B.7080800@zytor.com> Sender: linux-arch-owner@vger.kernel.org To: "H. Peter Anvin" , schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org Cc: "Luis R. Rodriguez" , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, boris.ostrovsky@oracle.com, rusty@rustcorp.com.au, david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com, ming.lei@canonical.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux@arm.linux.org.uk, benh@kernel.crashing.org, jbaron@akamai.com, ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, masami.hiramatsu.pt@hitachi.com, andriy.shevchenko@linux.intel.com, dwmw2@infradead.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Feb 19, 2016 at 12:26:51PM -0800, H. Peter Anvin wrote: > On 02/19/2016 05:45 AM, Luis R. Rodriguez wrote: > > With a generic linker tables solution in place we > > need a general asm solution for declaring entries > > with asm. The first easy target is to cover the C > > asm declarations, guard the header file for now > > and define a first generic entry push_section_tbl() > > to be used later for custom linker table annotations. > > > > Signed-off-by: Luis R. Rodriguez > > --- > > include/asm-generic/sections.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/asm-generic/sections.h b/include/asm-generic/sections.h > > index af0254c09424..f5ea98bd85d2 100644 > > --- a/include/asm-generic/sections.h > > +++ b/include/asm-generic/sections.h > > @@ -3,8 +3,10 @@ > > > > /* References to section boundaries */ > > > > +#ifndef __ASSEMBLY__ > > #include > > #include > > +#include > > > > /* > > * Usage guidelines: > > @@ -128,4 +130,12 @@ static inline bool init_section_intersects(void *virt, size_t size) > > return memory_intersects(__init_begin, __init_end, virt, size); > > } > > > > +/* > > + * Some architectures do not like the "\t" at the end (s39), we should be > > + * able to generalize this further, but so far this covers most architectures. > > + */ > > +#define push_section_tbl(section, name, level, flags) \ > > + ".pushsection " SECTION_TBL(section,name,level) ", \"" #flags "\"\n\t" > > +#endif > > + > > I think the \n\t is unnecessary. Super! I wonder if we we can just use this on s390 as well without it pooping? I ask as this would set a precedent. Luis