From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v2 3/3] xl: new "loglvl" command Date: Tue, 8 Mar 2016 16:20:55 +0000 Message-ID: <20160308162055.GN31271@citrix.com> References: <56D9C80702000078000D9910@prv-mh.provo.novell.com> <56D9CA6002000078000D9935@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adKNV-0004hA-EF for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 16:20:57 +0000 Content-Disposition: inline In-Reply-To: <56D9CA6002000078000D9935@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel , Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBNYXIgMDQsIDIwMTYgYXQgMDk6NDg6MTZBTSAtMDcwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gVGhpcyBpcyBwcmV0dHkgc2ltcGxpc3RpYyBmb3Igbm93LCBidXQgSSdkIHJhdGhlciBo YXZlIHNvbWVvbmUgYmV0dGVyCj4gZnJpZW5kcyB3aXRoIHRoZSB0b29scyBpbXByb3ZlIGl0IChp ZiBkZXNpcmVkKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+Cj4gCj4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGwuYwo+ICsrKyBiL3Rvb2xzL2xpYnhs L2xpYnhsLmMKPiBAQCAtNTk1OCw2ICs1OTU4LDI2IEBAIGludCBsaWJ4bF9zZW5kX2RlYnVnX2tl eXMobGlieGxfY3R4ICpjdHgKPiAgICAgIHJldHVybiAwOwo+ICB9Cj4gIAo+ICtpbnQgbGlieGxf bG9nX2xldmVsKGxpYnhsX2N0eCAqY3R4LCBib29sIHNldCwgYm9vbCBndWVzdCwKPiArICAgICAg ICAgICAgICAgICAgICBpbnQgKmxvd2VyX3RocmVzaCwgaW50ICp1cHBlcl90aHJlc2gpCj4gK3sK PiArICAgIGludCByZXQ7Cj4gKyAgICBHQ19JTklUKGN0eCk7Cj4gKyAgICBpZiAoc2V0KSB7Cj4g KyAgICAgICAgcmV0ID0geGNfc2V0X2xvZ19sZXZlbChjdHgtPnhjaCwgZ3Vlc3QsICpsb3dlcl90 aHJlc2gsICp1cHBlcl90aHJlc2gpOwo+ICsgICAgfSBlbHNlIHsKPiArICAgICAgICByZXQgPSB4 Y19nZXRfbG9nX2xldmVsKGN0eC0+eGNoLCBndWVzdCwgbG93ZXJfdGhyZXNoLCB1cHBlcl90aHJl c2gpOwo+ICsgICAgfQo+ICsgICAgaWYgKCByZXQgPCAwICkgewo+ICsgICAgICAgIExPR0UoRVJS T1IsICIlcyAlc2xvZyBsZXZlbCIsCj4gKyAgICAgICAgICAgICBzZXQgPyAic2V0dGluZyIgOiAi Z2V0dGluZyIsIGd1ZXN0ID8gImd1ZXN0ICIgOiAiIik7Cj4gKyAgICAgICAgR0NfRlJFRTsKPiAr ICAgICAgICByZXR1cm4gRVJST1JfRkFJTDsKPiArICAgIH0KPiArICAgIEdDX0ZSRUU7Cj4gKyAg ICByZXR1cm4gMDsKPiArfQo+ICsKCkFzIERhcmlvIHNhaWQsIGxpYnhsIHRlbmRzIHRvIGhhdmUg Z2V0dGVyIGFuZCBzZXR0ZXIgcGFpci4KCj4gIGxpYnhsX3hlbl9jb25zb2xlX3JlYWRlciAqCj4g ICAgICBsaWJ4bF94ZW5fY29uc29sZV9yZWFkX3N0YXJ0KGxpYnhsX2N0eCAqY3R4LCBpbnQgY2xl YXIpCj4gIHsKWy4uLl0KPiAgCj4gIC8qCj4gLS0tIGEvdG9vbHMvbGlieGwveGxfY21kaW1wbC5j Cj4gKysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCj4gQEAgLTY0NjksNiArNjQ2OSw4NCBA QCBpbnQgbWFpbl9kZWJ1Z19rZXlzKGludCBhcmdjLCBjaGFyICoqYXJnCj4gICAgICByZXR1cm4g MDsKPiAgfQo+ICAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCB7Cj4gKyAgICBpbnQgbGV2ZWw7Cj4g KyAgICBjaGFyIHN0cmluZ1s4XTsKPiArfSBsb2dsdmxzW10gPSB7Cj4gKyAgICB7IDAsICJub25l IiB9LAo+ICsgICAgeyAxLCAiZXJyb3IiIH0sCj4gKyAgICB7IDIsICJ3YXJuaW5nIiB9LAo+ICsg ICAgeyAzLCAiaW5mbyIgfSwKPiArICAgIHsgNCwgImFsbCIgfSwKPiArICAgIHsgNCwgImRlYnVn IiB9LAoKVGhlIHNlbWFudGljcyBvZiB0aGUgbnVtYmVycyBzaG91bGQgZ28gaW50byBsaWJ4bF90 eXBlcy5pZGwuIE1heWJlCnNvbWV0aGluZyBsaWtlCgojIEtlZXAgaW4gc3luYyB3aXRoIFhlbiBs b2cgbGV2ZWwuCmxpYnhsX3hlbl9sb2dfbGV2ZWwgPSBFbnVtZXJhdGlvbiAoLi4uKTsKClRoZW4g aW4gaGVyZQoKICAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgewogICAgICAgIGludCBsZXZlbDsKICAg ICAgICBjaGFyIHN0cmluZ1s4XTsKICAgIH0gbG9nbHZsc1tdID0gewogICAgICAgIHsgTElCWExf WEVOX0xPR19MRVZFTF9OT05FLCAibm9uZSIgfSwKICAgICAgICB7IC4uLiwgImVycm9yIiB9LAog ICAgICAgIHsgLi4uLCAid2FybmluZyIgfSwKICAgICAgICB7IC4uLiwgImluZm8iIH0sCiAgICAg ICAgeyAuLi4sICJhbGwiIH0sCiAgICAgICAgeyAuLi4sICJkZWJ1ZyIgfSwKClBsZWFzZSBhbHNv IG5vdGUgdGhhdCBhZnRlciB0aGUgaW50cm9kdWN0aW9uIG9mIHRoaXMgQVBJLCBYZW4gbG9nIGxl dmVsCndpbGwgYmVjb21lIHBhcnQgb2YgdGhlIHN0YWJsZSBBUEkgYW5kIHN1YmplY3QgdG8gc29t ZSBjb21wYXRpYmlsaXR5CmNvbnN0cmFpbnRzLiBJcyB0aGlzIHdoYXQgeW91IHdhbnRlZD8KCgo+ ICt9Owo+ICsKPiArc3RhdGljIGludCBwYXJzZV9sb2dsdmwoY2hhciAqKnBhcmcpCj4gK3sKPiAr ICAgIHVuc2lnbmVkIGludCBpOwo+ICsKPiArICAgIGZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpF KGxvZ2x2bHMpOyArK2kpIHsKPiArICAgICAgICBzaXplX3QgbCA9IHN0cmxlbihsb2dsdmxzW2ld LnN0cmluZyk7Cj4gKwo+ICsgICAgICAgIGlmICghc3RybmNtcCgqcGFyZywgbG9nbHZsc1tpXS5z dHJpbmcsIGwpKSB7Cj4gKyAgICAgICAgICAgICpwYXJnICs9IGw7Cj4gKyAgICAgICAgICAgIHJl dHVybiBsb2dsdmxzW2ldLmxldmVsOwo+ICsgICAgICAgIH0KPiArICAgIH0KPiArCj4gKyAgICBy ZXR1cm4gLTE7Cj4gK30KPiArCj4gK3N0YXRpYyBjb25zdCBjaGFyICpmb3JtYXRfbG9nbHZsKGlu dCBsb2dsdmwpCj4gK3sKPiArICAgIHVuc2lnbmVkIGludCBpOwo+ICsKPiArICAgIGZvciAoaSA9 IDA7IGkgPCBBUlJBWV9TSVpFKGxvZ2x2bHMpOyArK2kpIHsKPiArICAgICAgICBpZiAobG9nbHZs ID09IGxvZ2x2bHNbaV0ubGV2ZWwpCj4gKyAgICAgICAgICAgIHJldHVybiBsb2dsdmxzW2ldLnN0 cmluZzsKPiArICAgIH0KPiArCj4gKyAgICByZXR1cm4gIjx1bmtub3duPiI7Cj4gK30KPiArCj4g K2ludCBtYWluX2xvZ2x2bChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gK3sKPiArICAgIHN0YXRp YyBjb25zdCBzdHJ1Y3Qgb3B0aW9uIG9wdHNbXSA9IHsKPiArICAgICAgICB7Imd1ZXN0IiwgMCwg MCwgJ2cnfSwKPiArICAgICAgICB7InNldCIsIDAsIDAsICdzJ30sCj4gKyAgICAgICAgQ09NTU9O X0xPTkdfT1BUUwo+ICsgICAgfTsKPiArICAgIGludCBvcHQsIGxvd2VyX3RocmVzaCA9IC0xLCB1 cHBlcl90aHJlc2ggPSAtMTsKPiArICAgIGJvb2wgZ3Vlc3QgPSBmYWxzZSwgc2V0ID0gZmFsc2U7 Cj4gKwo+ICsgICAgU1dJVENIX0ZPUkVBQ0hfT1BUKG9wdCwgImdzOiIsIG9wdHMsICJsb2dsdmwi LCAwKSB7Cj4gKyAgICBjYXNlICdnJzoKPiArICAgICAgICBndWVzdCA9IHRydWU7Cj4gKyAgICAg ICAgYnJlYWs7Cj4gKyAgICBjYXNlICdzJzoKPiArICAgICAgICBpZiAoKm9wdGFyZyAhPSAnLycp Cj4gKyAgICAgICAgICAgIGxvd2VyX3RocmVzaCA9IHBhcnNlX2xvZ2x2bCgmb3B0YXJnKTsKPiAr ICAgICAgICBpZiAoKm9wdGFyZyA9PSAnLycpIHsKPiArICAgICAgICAgICAgKytvcHRhcmc7Cj4g KyAgICAgICAgICAgIHVwcGVyX3RocmVzaCA9IHBhcnNlX2xvZ2x2bCgmb3B0YXJnKTsKPiArICAg ICAgICB9Cj4gKyAgICAgICAgc2V0ID0gdHJ1ZTsKPiArICAgICAgICBicmVhazsKPiArICAgIH0K PiArCj4gKyAgICBpZiAobGlieGxfbG9nX2xldmVsKGN0eCwgc2V0LCBndWVzdCwgJmxvd2VyX3Ro cmVzaCwgJnVwcGVyX3RocmVzaCkpIHsKPiArICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImNhbm5v dCAlcyAlcyBsb2cgbGV2ZWxcbiIsCj4gKyAgICAgICAgICAgICAgICBzZXQgPyAic2V0IiA6ICJn ZXQiLCBndWVzdCA/ICJndWVzdCIgOiAiaG9zdCIpOwo+ICsgICAgICAgIHJldHVybiAxOwo+ICsg ICAgfQo+ICsKPiArICAgIGlmICghc2V0KQo+ICsgICAgICAgIHByaW50ZigiJXMgbG9nIGxldmVs czogJXMvJXNcbiIsIGd1ZXN0ID8gImd1ZXN0IiA6ICJob3N0IiwKPiArICAgICAgICAgICAgICAg Zm9ybWF0X2xvZ2x2bChsb3dlcl90aHJlc2gpLCBmb3JtYXRfbG9nbHZsKHVwcGVyX3RocmVzaCkp Owo+ICsKPiArICAgIHJldHVybiAwOwo+ICt9Cj4gKwoKWW91IGFsc28gbmVlZCB0byBwYXRjaCB4 bCBtYW5wYWdlLgoKV2VpLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK